fix(stages,blueprints): remove unused dead variables from 3-security and postgresql - #207
Open
aghassemlouei wants to merge 5 commits into
Open
fix(stages,blueprints): remove unused dead variables from 3-security and postgresql#207aghassemlouei wants to merge 5 commits into
aghassemlouei wants to merge 5 commits into
Conversation
…ute_global_address_name, and subnetwork_name (#112)
aghassemlouei
requested review from
Calvin-Cheng1,
LanceWray,
mgcarey-google and
woodham1
August 28, 2026 15:44
Collaborator
Author
|
@mgcarey-google would like someone else to take a peek at this. Adding additional reviewers and assignees. |
Collaborator
|
Agree with #112. Those are dead variables. For #113 while these variables are unused in security.tf, they are intended to be available and consumable in case there are modules/resources in stage 3 that require any previous outputs from 0-bootstrap, 1-resman, or 2-networking. I would prefer to keep them |
aghassemlouei
enabled auto-merge (squash)
August 28, 2026 20:52
Calvin-Cheng1
approved these changes
Aug 28, 2026
Calvin-Cheng1
left a comment
Collaborator
There was a problem hiding this comment.
LGTM after some changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request cleans up declared variables that are never referenced by resources, data sources, or locals:
core_project_id,google_compute_global_address_name, andsubnetwork_namefrom the PostgreSQL blueprint (variables.tf,terraform.tfvars.sample, andREADME.md).tenant_accountsfrom FAST Stage 3-security (variables.tfandREADME.md).Fixes #112
Fixes #113
Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/can be leveraged for this change.documentation/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
blueprints/il5/postgresqlandfast/stages-aw/3-security.