fix(gemini-enterprise): align stage-0 tfvars sample and make stage-1 internal subnet lookup configurable - #209
Open
aghassemlouei wants to merge 2 commits into
Open
Conversation
…urable with stage-0 fallback (#105)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses variable schema alignment and internal load balancer subnet lookup in the Gemini Enterprise blueprint:
gemini-stage-0/terraform.tfvars.samplewith actual variable schemas forgcs_data_store_configsandbq_data_store_configs(as maps of objects withcreate_dataset), and removes the undeclaredcreate_resource_keys.subnet_namevariable ingemini-stage-1and updates the internal load balancer subnet data source to resolve dynamically across Shared VPC and Greenfield deployments.Fixes #109
Fixes #105
Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/can be leveraged for this change.documentation/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
gemini-stage-0/terraform.tfvars.sampleagainstvariables.tfschemas.gemini-stage-1variable declarations and subnet lookup logic.