Skip to content

fix(gemini-enterprise): align stage-0 tfvars sample and make stage-1 internal subnet lookup configurable - #209

Open
aghassemlouei wants to merge 2 commits into
mainfrom
fix/gemini-enterprise-stage-schema-and-lb
Open

fix(gemini-enterprise): align stage-0 tfvars sample and make stage-1 internal subnet lookup configurable#209
aghassemlouei wants to merge 2 commits into
mainfrom
fix/gemini-enterprise-stage-schema-and-lb

Conversation

@aghassemlouei

Copy link
Copy Markdown
Collaborator

Description

This pull request addresses variable schema alignment and internal load balancer subnet lookup in the Gemini Enterprise blueprint:

Fixes #109
Fixes #105

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Deployment & Compliance Impact

  • Applicable Regimes:
    • US Region Restricted (e.g., Access Policy constraint)
    • FedRAMP Moderate
    • FedRAMP High
    • DoD IL4
    • DoD IL5
    • General / All
  • NIST 800-53r5 Controls: N/A

Checklist

Code Quality & Reusability

  • My code adheres to the Maximize Reusability principle. I have not redefined common elements and have reused existing base configurations and modules where possible.
  • I have checked that no existing module or configuration in modules/ or fast/ can be leveraged for this change.
  • My code follows the established naming conventions outlined in documentation/naming-convention.md.

Documentation

  • I have updated the README.md of the modified module or blueprint.
  • I have added/updated documentation for inputs (variables) and outputs.

Security

  • My change adheres to GCP security best practices and the principle of least privilege.
  • I have ensured compliance with the targeted regime (FedRAMP Moderate, FedRAMP High, IL5, etc.).

Testing

  • I have tested my changes locally.
  • I have included details of my testing in this PR.

Testing Performed

  • Validated gemini-stage-0/terraform.tfvars.sample against variables.tf schemas.
  • Validated gemini-stage-1 variable declarations and subnet lookup logic.

@aghassemlouei aghassemlouei added bug Something isn't working gemini enterprise Gemini Enterprise (GE) related gemini for government Gemini for Government (G4G) related labels Aug 28, 2026
@aghassemlouei aghassemlouei added Priority - Low Minor polish, typo fixes, or technical debt; nice to have; pick up when time permits Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete labels Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gemini enterprise Gemini Enterprise (GE) related gemini for government Gemini for Government (G4G) related Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - Low Minor polish, typo fixes, or technical debt; nice to have; pick up when time permits

Projects

None yet

2 participants