Skip to content

fix(2-networking-a-fedramp): encrypt NVA boot disk with the vdss KMS key - #211

Open
AloysJehwin wants to merge 1 commit into
google:mainfrom
AloysJehwin:fix/nva-boot-disk-cmek
Open

fix(2-networking-a-fedramp): encrypt NVA boot disk with the vdss KMS key#211
AloysJehwin wants to merge 1 commit into
google:mainfrom
AloysJehwin:fix/nva-boot-disk-cmek

Conversation

@AloysJehwin

Copy link
Copy Markdown
Contributor

Fixes #193

The FedRAMP High/Moderate networking stage builds a vdss-keyring HSM key and grants roles/cloudkms.cryptoKeyEncrypterDecrypter to both the NVA service account and the VDSS host project's compute service agent — and then nothing ever uses it. The NVA boot disks come up Google-managed, so those grants have no effect and the appliance disks aren't CMEK-encrypted.

The IL5 stage next door creates the identically-named key and actually wires it up, on the bastion disks and the NGFW VMs. This just brings the a-fedramp stage in line by passing the key to the NVA template.

I used the same top-level encryption block the IL5 bastion uses rather than reaching into boot_disk, since that's the module's supported surface. Worth noting the NVA sets create_template = true, so I checked the template path specifically — compute-vm's template disk block emits disk_encryption_key { kms_key_self_link } whenever var.encryption is non-null, so the boot disk does get encrypted here. (The encrypt_boot field on that variable is declared but never read anywhere in the module, so it doesn't gate this.)

No new variables and no change to the key, keyring or IAM — the grants that were already there are what makes this work.

The stage creates a vdss-keyring/default HSM key and grants
cryptoKeyEncrypterDecrypter to the NVA service account and the VDSS host
project compute service agent, but never references the key, so the NVA
boot disks stay Google-managed. The IL5 stage uses the identically-named
key on its bastion and NGFW disks.

Fixes google#193

Signed-off-by: Aloys Jehwin <aloysjehwin@gmail.com>
@aghassemlouei aghassemlouei added bug Something isn't working security Something is insecure or can be secured Priority - High Critical issues blocking development or users; urgent bugs or core features for release Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete labels Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - High Critical issues blocking development or users; urgent bugs or core features for release security Something is insecure or can be secured

Projects

None yet

2 participants