fix(scripts): follow the 2-networking-a-fedramp directory rename - #214
Open
scottonix wants to merge 1 commit into
Open
fix(scripts): follow the 2-networking-a-fedramp directory rename#214scottonix wants to merge 1 commit into
scottonix wants to merge 1 commit into
Conversation
Commit 7033b8c (google#162) renamed fast/stages-aw/2-networking-a-fedramp-high to 2-networking-a-fedramp, but deploy.sh, destroy.sh, restore.sh and clean.sh still cd into the old path. In deploy.sh the FedRAMP High/Moderate option of stage 2 therefore fails at 'cd ... || exit' before deploy_networking runs, and the other three scripts skip the stage the same way. Signed-off-by: Scott McDonald <scott.mcdonald@onixnet.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#162 (7033b8c) renamed
fast/stages-aw/2-networking-a-fedramp-highto2-networking-a-fedramp, and #173 (f64ce6c) updated the READMEs, but the four operator scripts stillcdinto the old path:scripts/deploy.sh:1066— the FedRAMP High/Moderate option of stage 2 fails atcd ... || exitbeforedeploy_networkingruns;scripts/destroy.sh:665and:1923;scripts/restore.sh:50;scripts/clean.sh:149.This replaces the five occurrences with the current directory name. No other change.
Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/can be leveraged for this change.documentation/naming-convention.md.Documentation
README.mdof the modified module or blueprint. (Not applicable — no documentation references the old path any more.)Security
Testing
Testing Performed
bash -non all four scripts: OK.shellcheck -S erroron all four scripts: no findings before or after the change.grep -rn 2-networking-a-fedramp-high scripts/returns nothing after the change;fast/stages-aw/2-networking-a-fedrampis the only FedRAMP networking directory in the tree.