Skip to content

fix(scripts): follow the 2-networking-a-fedramp directory rename - #214

Open
scottonix wants to merge 1 commit into
google:mainfrom
scottonix:fix/scripts-networking-stage-path
Open

fix(scripts): follow the 2-networking-a-fedramp directory rename#214
scottonix wants to merge 1 commit into
google:mainfrom
scottonix:fix/scripts-networking-stage-path

Conversation

@scottonix

Copy link
Copy Markdown

Description

#162 (7033b8c) renamed fast/stages-aw/2-networking-a-fedramp-high to 2-networking-a-fedramp, and #173 (f64ce6c) updated the READMEs, but the four operator scripts still cd into the old path:

  • scripts/deploy.sh:1066 — the FedRAMP High/Moderate option of stage 2 fails at cd ... || exit before deploy_networking runs;
  • scripts/destroy.sh:665 and :1923;
  • scripts/restore.sh:50;
  • scripts/clean.sh:149.

This replaces the five occurrences with the current directory name. No other change.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Deployment & Compliance Impact

  • Applicable Regimes:
    • US Region Restricted (e.g., Access Policy constraint)
    • FedRAMP Moderate
    • FedRAMP High
    • DoD IL4
    • DoD IL5
    • General / All
  • NIST 800-53r5 Controls: none affected.

Checklist

Code Quality & Reusability

  • My code adheres to the Maximize Reusability principle. I have not redefined common elements and have reused existing base configurations and modules where possible.
  • I have checked that no existing module or configuration in modules/ or fast/ can be leveraged for this change.
  • My code follows the established naming conventions outlined in documentation/naming-convention.md.

Documentation

  • I have updated the README.md of the modified module or blueprint. (Not applicable — no documentation references the old path any more.)
  • I have added/updated documentation for inputs (variables) and outputs. (Not applicable.)

Security

  • My change adheres to GCP security best practices and the principle of least privilege.
  • I have ensured compliance with the targeted regime (FedRAMP Moderate, FedRAMP High, IL5, etc.).

Testing

  • I have tested my changes locally.
  • I have included details of my testing in this PR.

Testing Performed

  • bash -n on all four scripts: OK.
  • shellcheck -S error on all four scripts: no findings before or after the change.
  • grep -rn 2-networking-a-fedramp-high scripts/ returns nothing after the change; fast/stages-aw/2-networking-a-fedramp is the only FedRAMP networking directory in the tree.

Commit 7033b8c (google#162) renamed fast/stages-aw/2-networking-a-fedramp-high to
2-networking-a-fedramp, but deploy.sh, destroy.sh, restore.sh and clean.sh
still cd into the old path. In deploy.sh the FedRAMP High/Moderate option of
stage 2 therefore fails at 'cd ... || exit' before deploy_networking runs, and
the other three scripts skip the stage the same way.

Signed-off-by: Scott McDonald <scott.mcdonald@onixnet.com>
@aghassemlouei aghassemlouei added bug Something isn't working Priority - High Critical issues blocking development or users; urgent bugs or core features for release Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete labels Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - High Critical issues blocking development or users; urgent bugs or core features for release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants