Skip to content

fix(2-networking-a-fedramp): validate proxy_subnets and tenant subnets up front #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scottonix wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

fix(2-networking-a-fedramp): validate proxy_subnets and tenant subnets up front #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion fast/stages-aw/2-networking-a-fedramp/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,13 +270,26 @@ variable "subnets" {
})))
default = {}
nullable = false
validation {
condition = alltrue([
for k in keys(var.envs_folders) :
try([for s in var.subnets[lower(k)] : s if s.tenant != null][0].region, null) == var.regions.primary
])
error_message = "Every environment in envs_folders needs a subnet list under subnets[lower(<env>)] whose first subnet with a non-null tenant is in regions.primary: the NVA landing routes, the connectivity-test addresses and the stage outputs all index that subnet."
}
}

variable "proxy_subnets" {
description = "VPC proxy-only subnet CIDRs keyed by environment."
description = "VPC proxy-only subnet CIDRs keyed by environment. One entry per key of envs_folders is required: every environment spoke gets a proxy-only subnet in regions.primary."
type = map(string)
default = {}
nullable = false
validation {
condition = alltrue([
for k in keys(var.envs_folders) : contains(keys(var.proxy_subnets), k)
])
error_message = "proxy_subnets needs an entry for every key of envs_folders (keys are case-sensitive and match envs_folders, not their lower-cased form): each environment spoke is created with a proxy-only subnet whose CIDR comes from this map."
}
}

variable "dns_policy_rules" {
Expand Down