Skip to content

Updating the default intervals used for short-term long-term skip subrelease. #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Aug 26, 2026
+6 −6
Merged

Updating the default intervals used for short-term long-term skip subrelease. #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tcmalloc/parameters.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ static std::atomic<int64_t>& skip_subrelease_short_interval_ns() {
#if defined(TCMALLOC_INTERNAL_SMALL_BUT_SLOW)
interval = absl::ZeroDuration();
#else
interval = absl::Seconds(60);
interval = absl::Seconds(10);
#endif

absl::base_internal::LowLevelCallOnce(&flag, [&]() {
Expand All @@ -127,7 +127,7 @@ static std::atomic<int64_t>& skip_subrelease_long_interval_ns() {
#if defined(TCMALLOC_INTERNAL_SMALL_BUT_SLOW)
interval = absl::ZeroDuration();
#else
interval = absl::Seconds(300);
interval = absl::Seconds(120);
#endif

absl::base_internal::LowLevelCallOnce(&flag, [&]() {
Expand Down
4 changes: 2 additions & 2 deletions tcmalloc/testing/default_parameters_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ constexpr absl::Duration kDefaultSkipSubreleaseShortInterval =
#if defined(TCMALLOC_INTERNAL_SMALL_BUT_SLOW)
absl::ZeroDuration()
#else
absl::Seconds(60)
absl::Seconds(10)
#endif
;
constexpr MallocExtension::BytesPerSecond kDefaultBackgroundReleaseRate{
Expand All @@ -46,7 +46,7 @@ constexpr absl::Duration kDefaultSkipSubreleaseLongInterval =
#if defined(TCMALLOC_INTERNAL_SMALL_BUT_SLOW)
absl::ZeroDuration()
#else
absl::Seconds(300)
absl::Seconds(120)
#endif
;

Expand Down
4 changes: 2 additions & 2 deletions tcmalloc/testing/get_stats_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,10 @@ TEST_F(GetStatsTest, Pbtxt) {
#else
EXPECT_THAT(
buf,
HasSubstr("tcmalloc_skip_subrelease_short_interval_ns: 60000000000"));
HasSubstr("tcmalloc_skip_subrelease_short_interval_ns: 10000000000"));
EXPECT_THAT(
buf,
HasSubstr("tcmalloc_skip_subrelease_long_interval_ns: 300000000000"));
HasSubstr("tcmalloc_skip_subrelease_long_interval_ns: 120000000000"));
#endif

EXPECT_THAT(buf, HasSubstr("tcmalloc_release_partial_alloc_pages: true"));
Expand Down
Loading