Add defaulted-off option to gate madvise'ing sampled allocations. - #545
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Add defaulted-off option to gate madvise'ing sampled allocations.#545copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Due to allocation reuse, we may trend towards the entire allocation being resident over time, even if it is not used. Consider: * Allocate 256KB. Write to it in its entirety. Free it. * Allocate 256KB again. Write to the first 128KB. Our residency telemetry will show the second allocation as fully resident, and many of those bytes (the upper half) as inactive. Our resident and zero telemetry is better equipped if it can answer accurately about the live allocation being profiled rather than the history of the address space. PiperOrigin-RevId: 968641102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add defaulted-off option to gate madvise'ing sampled allocations.
Due to allocation reuse, we may trend towards the entire allocation being
resident over time, even if it is not used. Consider:
Our residency telemetry will show the second allocation as fully resident, and
many of those bytes (the upper half) as inactive. Our resident and zero
telemetry is better equipped if it can answer accurately about the live
allocation being profiled rather than the history of the address space.