Conversation
…g, and quote @ and comma in quotePowerShell - In src/core.ts, fallback to usePwsh() / usePowerShell() when useBash() throws on Windows, preventing 'No quote function is defined' on clean Windows environments. - In src/util.ts, remove '@' and ',' from unquoted character whitelist in quotePowerShell to prevent PowerShell splatting variable expansion and array grouping parameter corruption. - Add regression tests for quotePowerShell in test/util.test.js.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR addresses two platform and parameter handling issues in
zx:Windows Default Shell Fallback (
src/core.ts):On standard Windows environments where
bashis not inPATH,useBash()throws during module initialization. Previously, the error was caught silently without assigning a fallback shell, leaving$.quoteundefined and causing any subsequent command execution with$to throwNo quote function is defined.This change adds a fallback to
usePwsh()/usePowerShell()whenuseBash()fails onwin32.PowerShell Argument Splatting & Grouping Prevention (
src/util.ts):In
quotePowerShell,@and,were previously included in the unquoted character whitelist. In PowerShell,@is the splatting operator and,is the array construction operator. Passing unquoted@argcauses PowerShell to attempt variable expansion, resulting in silent argument omission or replacement.Removing
@and,from the unquoted set ensures they are safely enclosed in single quotes.Checks
test/util.test.js.