Skip to content

feat(auth): add retry loop for generate_id_token#6090

Open
alvarowolfx wants to merge 1 commit into
googleapis:mainfrom
alvarowolfx:auth-generate-id-token-retry
Open

feat(auth): add retry loop for generate_id_token#6090
alvarowolfx wants to merge 1 commit into
googleapis:mainfrom
alvarowolfx:auth-generate-id-token-retry

Conversation

@alvarowolfx

Copy link
Copy Markdown
Contributor

Towards #4459

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a GenerateIdTokenClient with an internal retry loop to handle token generation. However, the review feedback points out that this creates nested retry loops because the token provider is already wrapped in an outer retry mechanism. This nested structure can lead to retry storms and ignores user-configured retry policies. It is recommended to remove the inner retry loop and let the outer provider handle retries.

Comment thread src/auth/src/credentials/idtoken/impersonated.rs
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.87500% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.04%. Comparing base (2f59820) to head (be4318e).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/auth/src/credentials/idtoken/impersonated.rs 96.87% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6090    +/-   ##
========================================
  Coverage   97.04%   97.04%            
========================================
  Files         253      253            
  Lines       63682    63792   +110     
========================================
+ Hits        61798    61906   +108     
- Misses       1884     1886     +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alvarowolfx
alvarowolfx marked this pull request as ready for review July 17, 2026 18:35
@alvarowolfx
alvarowolfx requested review from a team as code owners July 17, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant