feat(auth): add retry loop for generate_id_token#6090
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a GenerateIdTokenClient with an internal retry loop to handle token generation. However, the review feedback points out that this creates nested retry loops because the token provider is already wrapped in an outer retry mechanism. This nested structure can lead to retry storms and ignores user-configured retry policies. It is recommended to remove the inner retry loop and let the outer provider handle retries.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6090 +/- ##
========================================
Coverage 97.04% 97.04%
========================================
Files 253 253
Lines 63682 63792 +110
========================================
+ Hits 61798 61906 +108
- Misses 1884 1886 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Towards #4459