feat: add public grpc feature flag for hybrid clients (#6095)#6098
feat: add public grpc feature flag for hybrid clients (#6095)#6098mahendrarathore1742 wants to merge 2 commits into
Conversation
- Add public feature flag to gax and gax-internal crates - Gate gax streaming module under #[cfg(all(feature = grpc, google_cloud_unstable_gapic_streaming))] - Update docs.rs metadata to include grpc feature - Add cfg(google_cloud_unstable_grpc) to workspace check-cfg
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new grpc feature flag across the gax and gax-internal crates to gate gRPC transport and streaming capabilities, updating documentation metadata and conditional compilation attributes accordingly. Feedback suggests ensuring that enabling the grpc feature in google-cloud-gax-internal also propagates and enables the grpc feature in google-cloud-gax to prevent potential compilation or missing functionality issues.
| _default-rustls-provider = ["google-cloud-auth?/default-rustls-provider", "tonic?/tls-aws-lc"] | ||
| # Enable gRPC transport support. This is a public feature flag that enables | ||
| # gRPC streaming capabilities in client libraries. | ||
| grpc = ["_internal-grpc-client"] |
There was a problem hiding this comment.
When the grpc feature is enabled in google-cloud-gax-internal, it should also enable the corresponding grpc feature in google-cloud-gax. Otherwise, the streaming module in google-cloud-gax (which is gated by feature = "grpc") will not be compiled, leading to compilation errors or missing functionality when gRPC streaming is expected.
| grpc = ["_internal-grpc-client"] | |
| grpc = ["_internal-grpc-client", "google-cloud-gax/grpc"] |
1 participant
fix #6095