You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Long Codex conversations could not continue because thread/resume returned their historical turns in a single JSON frame, exceeding the SDK's default 2 MiB limit. Request excludeTurns: true for resume and its active-writer fork fallback. Codex retains the saved context; only the response history is omitted. New-thread requests and the frame limit stay unchanged.
Evidence
Affected thread: read-only thread/read with includeTurns: true returned 2,889,662 bytes (16 turns); about 2.66 MB was command-execution items.
Actual thread/resume with excludeTurns: true on the same thread succeeded: 1,993 bytes, zero returned historical turns. No prompt/model turn sent.
cargo test --locked resume_and_writer_conflict_fork_exclude_historical_turns failed before the fix (Null versus true).
cargo test --locked --all-features: 312 passed, 1 existing ignored test.
The generated schema from the installed Codex CLI documents excludeTurns on both resume and fork. An existing handshake regression verifies a metadata-only resume response still starts the next turn.
The PR appears safe to merge; the resume optimization is covered by focused tests and the prior documentation discoverability issue is fully addressed.
The reason will be displayed to describe this comment to others. Learn more.
Guide Is Not Discoverable
The documentation portal uses an explicit page registry, but this new guide is not registered there. As a result, users cannot find it through the portal navigation or search. Add it to site/src/content/docs.ts alongside the other how-to guides.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long Codex conversations could not continue because
thread/resumereturned their historical turns in a single JSON frame, exceeding the SDK's default 2 MiB limit. RequestexcludeTurns: truefor resume and its active-writer fork fallback. Codex retains the saved context; only the response history is omitted. New-thread requests and the frame limit stay unchanged.Evidence
thread/readwithincludeTurns: truereturned 2,889,662 bytes (16 turns); about 2.66 MB was command-execution items.thread/resumewithexcludeTurns: trueon the same thread succeeded: 1,993 bytes, zero returned historical turns. No prompt/model turn sent.cargo test --locked resume_and_writer_conflict_fork_exclude_historical_turnsfailed before the fix (Nullversustrue).cargo test --locked --all-features: 312 passed, 1 existing ignored test.cargo clippy --locked --all-targets --all-features -- -D warnings: passed.cargo check --lib --locked: passed.cargo fmt --allandgit diff --check: passed.The generated schema from the installed Codex CLI documents
excludeTurnson both resume and fork. An existing handshake regression verifies a metadata-only resume response still starts the next turn.