Repository navigation
Conversation
A content API page keeps its details in api_v2's columns, so the editor now edits them as fields beside the body and converts only the Markdown body. Browser drafts keep their YAML frontmatter. Download my version saves the whole unsaved page, details and body, as JSON, since the body alone would lose the details.
Amplify PR previews
Commit:
|
2 of 3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A content API page keeps its details (title, introduction, description, path, category, visibility and form) in api_v2's own columns. Until now the editor round-tripped them through YAML frontmatter. With this PR, the editor edits them as fields and converts only the Markdown body.
src/workspace/page-details.ts(thePageDetailstype,detailsOf,sameDetails,detailsProblems) andpage-details-panel.tsx. The details autosave beside the body, and each field keeps its own undo.page.json, in the shape a save sends:{ ...details, body_markdown }. Before, it saved only the body, which would have lost unsaved details.Test plan
apps/editor_v2: format, lint, typecheck, boundaries, the full suite (1068), andbuildwithVITE_API_ORIGINset