Repository navigation
[release] attach sources and javadoc to starter - #37
Merged
Merged
Conversation
Maven Central requires -sources and -javadoc jars for every jar module. The starter built neither, so Central rejected the v1.0.2 deployment as a whole and nothing was published.
devan-kuleindiren
approved these changes
Oct 22, 2026
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first release, v1.0.2, failed at the Maven Central publish step:
Deployment d67cf8a0-13b1-4f52-a8ac-75f1187866b8 (Deployment) failed while publishing. Central publishes all-or-nothing, so nothing was released (the 1.0.2 pom on repo1 still returns 404).Why
Central requires
-sources.jarand-javadoc.jarfor every jar module.gradient-labs-clientdeclaresmaven-source-pluginandmaven-javadoc-plugin;gradient-labs-spring-boot-starterdeclared neither. In the release log, the client signs 4 files and the starter only 2 (pom and jar).The plugin doesn't print Sonatype's validation errors, so this is inferred from the log rather than confirmed in the portal. Signing, auth and upload all worked, so the GPG key, credentials and namespace are fine.
What
Add the two plugins to the starter's
<build>, the same way the client does it. Versions and executions come from the root pom'spluginManagement.Testing
mvn package -DskipTestson Maven 3.9 / JDK 25 (Docker): the starter now produces-1.0.2-sources.jarand-1.0.2-javadoc.jarnext to its jar, matching the client.Releasing after merge
Tag
v1.0.2exists on5be75de(before this fix). Nothing was published under it, so it can be moved to the new merge commit, or we tagv1.0.3instead.