fix: validate @fromContext reachability during composition - #335
Merged
Merged
Conversation
Contributor
jdolle
approved these changes
Sep 21, 2026
jdolle
left a comment
jdolle
left a comment
Contributor
There was a problem hiding this comment.
Looks well covered, fixes a couple other lower priority bugs, and may even improve performance.
kamilkisiela
force-pushed
the
context-satisfy
branch
from
September 23, 2026 08:05
6dc371c to
45099c0
Compare
kamilkisiela
pushed a commit
that referenced
this pull request
Sep 23, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @theguild/federation-composition@0.27.0 ### Minor Changes - [#335](#335) [`faabae5`](faabae5) Thanks [@kamilkisiela](https://github.com/kamilkisiela)! - Add satisfiability checking for `@fromContext` arguments Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plus few optimizations and dead code drop