Repository navigation
Conversation
Fixes grll#91. Treat integer second counts like the default 5 when building ClientSession timeouts, and add regression coverage.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treat integer second counts (including the default
5) as validclient_session_timeout_secondsvalues when constructing MCPClientSessiontimeouts.Motivation
Fixes #91. The default timeout is the integer
5, butmcptoolsonly convertedfloatandtimedeltavalues. With the default argument,timeoutstayedNone, so the documented 5-second session timeout was never applied.Changes
intandfloatsecond counts (excludingbool) when building thetimedeltapassed toClientSession.mcptoolsandMCPAdapt.__init__.5and the default path.Tests
python3 -m pytest tests/test_core.py::test_mcptools_converts_int_client_session_timeout tests/test_core.py::test_client_session_timeout_parameter_propagation -q→ 2 passedNotes
Minimal behavior change; existing
float,timedelta, andNonehandling is unchanged.