Skip to content

ci: test Python matrix against locked dependencies - #2498

Open
groupthinking wants to merge 1 commit into
mainfrom
codex/ci-test-locked-python-deps
Open

groupthinking wants to merge 1 commit into
mainfrom
codex/ci-test-locked-python-deps

Conversation

@groupthinking

@groupthinking groupthinking commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Summary

Closes #2497 on merge.

The Python 3.11/3.12 CI jobs currently validate uv.lock but then install .[dev,youtube] with pip, which resolves packages independently. That leaves lockfile-only updates such as #2486 with green Python tests that did not use the proposed versions.

This PR installs the committed lockfile for each matrix interpreter with the same dev and youtube extras, then runs the unit and offline MCP tests through that environment. It updates the workflow-governance test to enforce step ordering and that both test steps use the locked interpreter. The existing matrix, test selection, coverage arguments, and failure behavior remain intact.

Paths changed

  • .github/workflows/ci.yml
  • tests/unit/test_gh_aw_workflow_governance.py

Validation

  • uv sync --locked --python /opt/homebrew/bin/python3.11 --extra dev --extra youtube --quiet — passed locally.
  • uv sync --locked --python /opt/homebrew/bin/python3.12 --extra dev --extra youtube --quiet — passed locally.
  • Unit gate using each locked interpreter, with two existing tests that fail on this macOS host excluded — 2,966 passed, 11 deselected, 5 xpassed, 118 subtests passed per interpreter. This local exclusion is not in the CI workflow.
  • Offline MCP inventory and approval regressions using each locked interpreter — 38 passed, 20 subtests passed per interpreter.
  • Workflow-governance tests — 13 passed; workflow YAML parsed; git diff --check passed.

Hosted validation at 42a1d4b9c65fd04871e0f377722650c39b02ff71

  • CI run 40731031423 completed successfully. The Python 3.11 and 3.12 jobs each executed uv sync --locked --python for their matrix version, installed the locked dependencies, and passed 2,968 unit tests, 9 deselected, 5 xpassed, and 118 subtests, followed by 38 offline MCP tests and 20 subtests. No local macOS test exclusions were applied in hosted CI.
  • At 17:03 UTC on October 28, the latest PR checks were 29 successful, 12 skipped, zero failed or pending. The PR was open and mergeable, with no unresolved inline review threads.

This CI repair is ready for a merge decision. It does not repair the separate dependency-review snapshot/report failure on #2486 or the original dependency PRs; those still need warning-free evidence after the shared workflow repair and branch refresh. No merge has occurred.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Oct 28, 2026 4:58pm UTC

Copilot AI balanced review requested due to automatic review settings October 28, 2026 16:57
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Required hosted Linux validation remains unconfirmed because Python 3.11 unit tests were still running and its offline MCP step was pending.

No open issues 🎉

What changed in this PR

Addresses #2497 by making the Python CI matrix test dependencies installed from the committed uv.lock, rather than independently resolved pip packages.

Changes:

  • Installs locked dependencies with the dev and youtube extras for Python 3.11 and 3.12.
  • Runs unit and offline MCP tests through .venv/bin/python, preserving existing test selection, coverage settings, and failure behavior.
  • Strengthens workflow-governance assertions for installation order and locked-environment usage.

Hosted Linux validation for both Python versions remains required; the separate dependency-review failure is outside this PR’s scope.

File Description
tests/​unit/​test_gh_aw_workflow_governance.py Enforces locked installation, step ordering, and test interpreter usage.
.github/​workflows/​ci.yml Installs from uv.lock and runs both test steps in the resulting environment.

Review effort: Balanced

This branch was successfully deployed

1 active deployment
Preview — 42a1d4b9 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run Python CI tests against the committed uv.lock

2 participants