Repository navigation
ci: test Python matrix against locked dependencies - #2498
groupthinking wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
There was a problem hiding this comment.
🔵 Needs a closer look
Required hosted Linux validation remains unconfirmed because Python 3.11 unit tests were still running and its offline MCP step was pending.
No open issues 🎉
What changed in this PR
Addresses #2497 by making the Python CI matrix test dependencies installed from the committed uv.lock, rather than independently resolved pip packages.
Changes:
- Installs locked dependencies with the
devandyoutubeextras for Python 3.11 and 3.12. - Runs unit and offline MCP tests through
.venv/bin/python, preserving existing test selection, coverage settings, and failure behavior. - Strengthens workflow-governance assertions for installation order and locked-environment usage.
Hosted Linux validation for both Python versions remains required; the separate dependency-review failure is outside this PR’s scope.
| File | Description |
|---|---|
tests/unit/test_gh_aw_workflow_governance.py |
Enforces locked installation, step ordering, and test interpreter usage. |
.github/workflows/ci.yml |
Installs from uv.lock and runs both test steps in the resulting environment. |
Review effort: Balanced
Summary
Closes #2497 on merge.
The Python 3.11/3.12 CI jobs currently validate
uv.lockbut then install.[dev,youtube]with pip, which resolves packages independently. That leaves lockfile-only updates such as #2486 with green Python tests that did not use the proposed versions.This PR installs the committed lockfile for each matrix interpreter with the same
devandyoutubeextras, then runs the unit and offline MCP tests through that environment. It updates the workflow-governance test to enforce step ordering and that both test steps use the locked interpreter. The existing matrix, test selection, coverage arguments, and failure behavior remain intact.Paths changed
.github/workflows/ci.ymltests/unit/test_gh_aw_workflow_governance.pyValidation
uv sync --locked --python /opt/homebrew/bin/python3.11 --extra dev --extra youtube --quiet— passed locally.uv sync --locked --python /opt/homebrew/bin/python3.12 --extra dev --extra youtube --quiet— passed locally.git diff --checkpassed.Hosted validation at
42a1d4b9c65fd04871e0f377722650c39b02ff71uv sync --locked --pythonfor their matrix version, installed the locked dependencies, and passed 2,968 unit tests, 9 deselected, 5 xpassed, and 118 subtests, followed by 38 offline MCP tests and 20 subtests. No local macOS test exclusions were applied in hosted CI.This CI repair is ready for a merge decision. It does not repair the separate
dependency-reviewsnapshot/report failure on #2486 or the original dependency PRs; those still need warning-free evidence after the shared workflow repair and branch refresh. No merge has occurred.