Skip to content

Persist complete dependency-review evidence across paginated compare diffs - #2516

Draft
groupthinking with Codex wants to merge 2 commits into
mainfrom
codex/persist-complete-dependency-review-evidence
Draft

groupthinking with Codex wants to merge 2 commits into
mainfrom
codex/persist-complete-dependency-review-evidence

Conversation

@Codex

@Codex Codex AI commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Canonical issue

#2503

Outcome

Large dependency PRs can return paginated dependency-graph compare results; previously only page 1 was persisted. This update captures the full compare dataset and keeps existing guards that reject incomplete evidence (snapshot warnings or graph drift).

Scope

  • Included:
    • Pagination handling: scripts/ci/record_dependency_review.py now follows Link: rel="next" and accumulates all pages before writing evidence.
    • Evidence integrity: keeps snapshot-warning hard-fail behavior and runs existing diff/manifest validation on the merged dataset.
    • Artifact semantics: writes a single merged dependency-diff.json for multi-page responses and computes hash/count from the complete payload.
    • Regression coverage: adds a unit test proving multi-page fetch + persistence behavior.
  • Explicitly excluded:
    • Workflow trigger/permissions changes.
    • Dependency policy changes (license/severity allowlists, advisory handling).
    • Any relaxations to snapshot-warning or graph-drift checks.

Risk

  • Risk level: low
  • Failure mode:
    • Misparsed Link headers could truncate data or over-fetch.
    • API schema drift (non-list/invalid items) still fails closed.
  • Rollback:
    • Revert scripts/ci/record_dependency_review.py and the paired unit test.

Verification

List exact automated and manual checks, tied to the current head SHA.

  • Focused tests
  • Required CI
  • Review threads resolved

Production evidence

Not applicable; CI evidence artifact behavior only (no runtime/product-surface change).

Agent handoff

  • One canonical issue is linked
  • No competing PR implements the same issue
  • Acceptance criteria are satisfied
  • Required checks pass on the current head
  • Human decision is requested only for product, security, irreversible infrastructure, or production approval

Security dependency evidence

Not applicable (this PR changes dependency-review evidence collection logic; it does not introduce an advisory-driven dependency update).

Example (new behavior)

# page 1: Link header points to page 2
# page 2: final page
# recorder now persists page1 + page2 as one dependency-diff.json before hashing/counting

@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Oct 30, 2026 6:14am UTC

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 3
  • WIP
  • DO NOT MERGE
  • [skip ci]

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
@Codex Codex AI changed the title [WIP] Fetch and validate dependency compare diff for large PRs Persist complete dependency-review evidence across paginated compare diffs Oct 30, 2026
@Codex
Codex AI requested a review from groupthinking October 30, 2026 06:15

This branch was successfully deployed

1 active deployment
Preview — 128bb5ec Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Persist complete dependency review evidence for large PRs

2 participants