🚀 Release/v4.9.1

.circleci/config.yml

@@ -67,13 +67,15 @@ jobs:
   unit-test:
     executor:
       name: android/android_docker
-      resource_class: large
       tag: 2024.07.1-ndk
+      resource_class: large
+    environment:
+      GRADLE_OPTS: "-Dorg.gradle.jvmargs=-Xmx4g -XX:MaxMetaspaceSize=512m -Dorg.gradle.daemon=false -Dorg.gradle.workers.max=2"
     steps:
       - setup_environment
       - run:
           name: "Execute Unit Tests"
-          command: ./gradlew testBrainwalletDebugUnitTest --no-daemon --max-workers=2 -Dorg.gradle.jvmargs="-Xmx8g" -Dkotlin.compiler.execution.strategy=in-process
+          command: ./gradlew testBrainwalletDebugUnitTest --no-daemon --max-workers=2
       - android/save_gradle_cache
       - run:
           name: Save test results

.github/workflows/auto-translate.yml

@@ -1,5 +1,4 @@
-name: Auto-Translate strings.xml
-
+name: 🇧🇷 🇳🇱 🇹🇭 Auto-Translate strings.xml
 on:
   push:
     branches:
@@ -51,7 +50,8 @@ jobs:
           git checkout -b "$BRANCH"
           git add app/src/main/res/values-*/strings.xml
           git commit -m "chore(i18n): auto-translate missing strings [skip ci]
-          Languages updated: ar, zh-rTW, zh-rCN, fr, de, fa, pa, pl, in, es, sv, uk, ru, tr, ja, ko, hi, it, pt-rBR
+
+          Languages updated: ar, de, es, fa, fr, hi, in, it, ja, ko, nl, pa, pl, pt-rBR, ru, sv, th, tr, uk, zh-rCN, zh-rTW
           Triggered by: ${{ github.sha }}
           "
           git push origin "$BRANCH"
@@ -63,7 +63,7 @@ jobs:
           gh pr create \
             --title "🌍 Auto-translations: missing strings updated" \
             --body "$(cat /tmp/pr_body.md)" \
-            --base main \
+            --base develop \
             --head "$BRANCH" \
             --label "translations" \
             --reviewer "${{ github.actor }}"

.github/workflows/notify.yml

@@ -0,0 +1,27 @@
+name: Notify Mirror on PR
+
+on:
+  pull_request:
+    types: [opened, synchronize, reopened]
+
+jobs:
+  trigger-mirror:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Trigger mirror workflow
+        uses: actions/github-script@v7
+        with:
+          github-token: ${{ secrets.MIRROR_REPO_TOKEN }}
+          script: |
+            await github.rest.actions.createWorkflowDispatch({
+              owner: 'gruntsoftware',
+              repo: 'brainwallet-android',
+              workflow_id: 'sync.yml',
+              ref: 'main',
+              inputs: {
+                source: '${{ github.event.repository.name }}',
+                pr_number: '${{ github.event.pull_request.number }}',
+                pr_title: '${{ github.event.pull_request.title }}',
+                branch: '${{ github.head_ref }}'
+              }
+            })

.github/workflows/pr-summary-copilot.yml

@@ -2,7 +2,7 @@ name: 🤖 Copilot PR Summary
 
 on:
   pull_request:
-    types: [opened, synchronize, reopened]
+    types: [opened, reopened]
     branches:
       - develop
       - main

.gitignore

@@ -43,4 +43,7 @@ app/src/.DS_Store
 /app/src/main/assets/service-data.json
 /app/src/main/assets/canary-file.json
 service-data.json
-canary-file.json
+canary-file.json
+
+# Claude
+.claude/

README.md

@@ -7,9 +7,46 @@ The open source code of Brainwallet Android
 
 **develop**: [![CircleCI](https://dl.circleci.com/status-badge/img/gh/gruntsoftware/android/tree/develop.svg?style=svg)](https://dl.circleci.com/status-badge/redirect/gh/gruntsoftware/android/tree/develop)
 
-## Release Notes
-### v4.8.3
+
 # 🚀 Brainwallet Android — Release Notes
+### v4.9.0
+
+### ✨ New Features
+
+#### 📋 Copy Transaction Details to Clipboard
+Transaction details can now be copied directly to the clipboard from the transaction detail view. A new `BRClipboardManager.putDetailsClipboard()` method handles the copy action with full analytics tracking, making it easy to share or reference transaction information outside the app.
+
+#### 📊 Analytics Tracking for Key Interactions
+Firebase analytics events are now fired for core user interactions — fiat/LTC toggle, balance visibility toggle, and transaction detail copy — giving the team better insight into how users engage with the wallet's main screens.
+
+---
+
+### 🎨 UI / Design System
+
+#### 🧱 Unified `bentoSurface` Design System
+A new `bentoSurface()` modifier in `BentoModifiers.kt` consolidates gradient and border styling across the entire bento UI. Previously hardcoded values like `1.dp` borders are now driven by shared constants (`bentoBorderWidth`, `bentoCornerRadius`, `bentoCornerRadius`, `bentoSpacer`, `transactionActionHt`, `transactionDetailHt`), making the visual system consistent and easy to maintain going forward.
+
+#### 🃏 Bento Section Refactors
+- **GameHub** — migrated from `Card` to `Box` with `bentoSurface()`, with a `clickable` modifier added
+- **Favourites** — refactored to `bentoSurface()` with improved `Spacer` layout
+- **LTC Picker** — label repositioned to top, spacing and item heights adjusted
+- **Transactions** — `TransactionFilter`, `TransactionsBentoScreen`, `ConfirmationStatus`, `CopyTransactionWidget`, `ExportTransactionsWidget`, `NoTxRow`, `TransactionDetail`, `TransactionFilterWidget`, `TransactionRow` all updated to unified styling
+- **Tutorials & Bottom Nav Bar** — updated to use unified theme system
+
+---
+
+### 🔧 Technical Changes
+- `MainScreen`, `MainScreenEvent`, and `MainViewModel` updated for new event handling and state management
+- `NoWifiBalanceAlertScreen` and `ReceiveDialog` border widths replaced with `bentoBorderWidth` constant
+- `strings.xml` updated with new/updated string resources
+- `gradle/libs.versions.toml` and `app/build.gradle.kts` dependencies updated
+- `detekt-app-baseline.xml` baseline updated
+- Version bumped: **v4.8.4 (202506314) → v4.9.0 (202506315)** 
+- Release/v4.7.2 202506296 by @kcw-grunt in https://github.com/gruntsoftware/android/pull/134
+- Release/v4.8.0 by @kcw-grunt in https://github.com/gruntsoftware/android/pull/145
+
+**Full Changelog**: https://github.com/gruntsoftware/android/compare/v4.7.2...v4.9.0
+### v4.8.3
 
 ## ✨ New UI — Favourites & Tutorials Bento Sections
 **PR [#191](https://github.com/gruntsoftware/android/pull/191)**

app/build.gradle.kts

@@ -1,4 +1,5 @@
 import com.android.build.gradle.internal.cxx.configure.gradleLocalProperties
+import org.gradle.kotlin.dsl.androidTestImplementation
 import org.gradle.kotlin.dsl.grunt
 
 plugins {
@@ -34,8 +35,8 @@ android {
         applicationId = "ltd.grunt.brainwallet"
         minSdk = 29
         targetSdk = 35
-        versionCode = 202506315
-        versionName = "v4.9.0"
+        versionCode = 202506323
+        versionName = "v4.9.1"
         multiDexEnabled = true
         base.archivesName.set("${defaultConfig.versionName}(${defaultConfig.versionCode})")
         testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
@@ -179,9 +180,18 @@ android {
     packaging {
         resources {
             pickFirsts.add("protobuf.meta")
+            excludes += setOf(
+                "META-INF/LICENSE.md",
+                "META-INF/LICENSE-notice.md",
+                "META-INF/NOTICE.md",
+                "META-INF/NOTICE",
+                "META-INF/LICENSE"
+            )
         }
     }
-
+        testFixtures {
+            enable = true
+        }
     //TODO: rename output apk/bundle
 }
 
@@ -190,6 +200,8 @@ dependencies {
     implementation(project(":iap"))
     implementation(project(":core"))
     implementation("androidx.webkit:webkit:1.9.0")
+    testImplementation(testFixtures(project(":app")))
+    androidTestImplementation(testFixtures(project(":app")))
     implementation(grunt.androidx.core.ktx)
     implementation(grunt.app.startup)
     implementation(libs.androidx.appcompat)
@@ -218,7 +230,6 @@ dependencies {
     implementation(libs.bundles.google.play.review)
     implementation(libs.kotlinx.serialization.json)
     implementation(libs.kotlinx.coroutines.android)
-    implementation (libs.airbnb.lottie.compose)
     implementation(platform(grunt.koin.bom))
     implementation(grunt.bundles.koin)
     implementation(platform(grunt.koin.annotation.bom))
@@ -229,6 +240,7 @@ dependencies {
     implementation(libs.androidx.runtime)
     implementation(libs.androidx.foundation)
     implementation(libs.androidx.animation)
+    implementation(libs.play.services.games)
     ksp(grunt.koin.annotation.compiler)
     implementation(platform(libs.squareup.okhttp.bom))
     implementation(libs.bundles.squareup.okhttp)
@@ -259,8 +271,14 @@ dependencies {
     androidTestImplementation(libs.bundles.android.test)
     androidTestImplementation(libs.fastlane.screengrab)
     androidTestImplementation(libs.slf4j.android)
+    androidTestImplementation("androidx.test.ext:junit:1.1.5")
+    androidTestImplementation("androidx.test:runner:1.5.2")
+    androidTestImplementation("androidx.test:rules:1.5.0")
+    androidTestImplementation("io.mockk:mockk-android:1.13.8")
+    androidTestImplementation("org.jetbrains.kotlinx:kotlinx-coroutines-test:1.7.3")
 }
 
 tasks.withType<Test> {
     jvmArgs("-XX:+EnableDynamicAgentLoading")
 }
+

app/src/androidTest/java/com/brainwallet/ui/screens/send/SendInstrumentationTest.kt

@@ -0,0 +1,164 @@
+package com.brainwallet.ui.screens.send
+
+import android.content.Context
+import androidx.test.core.app.ApplicationProvider
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import androidx.test.filters.LargeTest
+import com.brainwallet.presenter.entities.TransactionItem
+import com.brainwallet.tools.security.PostAuth
+import com.brainwallet.wallet.BRWalletManager
+import io.mockk.mockk
+import junit.framework.TestCase.assertFalse
+import kotlinx.coroutines.ExperimentalCoroutinesApi
+import kotlinx.coroutines.test.runTest
+import org.junit.Assume.assumeTrue
+import org.junit.Before
+import org.junit.Test
+import org.junit.jupiter.api.assertNotNull
+import org.junit.runner.RunWith
+import kotlin.test.DefaultAsserter.assertTrue
+
+/**
+ * Instrumentation tests that exercise [BWSender] against the REAL
+ * [com.brainwallet.wallet.BRWalletManager] JNI layer. These are the only way to catch regressions in
+ * the native boundary — MockK cannot stub native methods on the JVM.
+ *
+ * Run on an emulator/device where libcore.so and libbreadwallet.so are loaded.
+ *
+ * NOTE: These tests assume a wallet has been initialised by the test runner or
+ * a prior setup step. They `assumeTrue(isCreated)` so they are safely skipped
+ * on fresh installs rather than failing spuriously.
+ */
+@LargeTest
+@OptIn(ExperimentalCoroutinesApi::class)
+@RunWith(AndroidJUnit4::class)
+class SendInstrumentationTest {
+
+    private lateinit var context: Context
+    private lateinit var walletManager: BRWalletManager
+
+    @Before
+    fun setUp() {
+        context = ApplicationProvider.getApplicationContext()
+        walletManager = BRWalletManager.getInstance()
+    }
+
+    @Before
+    fun loadNativeLibrary() {
+        System.loadLibrary("core-lib")
+    }
+
+    // -------------------------------------------------------------------------
+    // Native address validation — the regression that crashed production
+    // -------------------------------------------------------------------------
+
+    @Test
+    fun validateAddress_acceptsKnownGoodLitecoinAddress() {
+        // Litecoin P2PKH sample address (starts with L).
+        val addr = "LcWHwzZitnqQsXwi6UScRjtjDFYjR7t24t"
+        assertTrue(
+            "Native validator must accept canonical L-prefix addresses",
+            BRWalletManager.getInstance().validateAddress(addr)
+        )
+    }
+
+    @Test
+    fun validateAddress_rejectsEmptyString() {
+        assertFalse(BRWalletManager.getInstance().validateAddress(""))
+    }
+
+    @Test
+    fun validateAddress_rejectsGarbage() {
+        assertFalse(BRWalletManager.getInstance().validateAddress("not-a-real-address"))
+    }
+
+    @Test
+    fun validateAddress_rejectsBitcoinAddress() {
+        // Bitcoin address should be rejected by a Litecoin wallet.
+        assertFalse(
+            BRWalletManager.getInstance().validateAddress("1A1zP1eP5QGefi2DMPTfTL5SLmv7DivfNa")
+        )
+    }
+
+    // -------------------------------------------------------------------------
+    // BWSender through the real JNI layer
+    // -------------------------------------------------------------------------
+
+    @Test
+    fun bwSender_withRealWalletManager_handlesNullTransactionGracefully() = runTest {
+        assumeTrue("Skipping — wallet not created on this device", walletManager.isCreated())
+
+        val postAuth = mockk<PostAuth>(relaxed = true)
+        val sender = BWSender(
+            context = context,
+            getWalletManager = { walletManager },
+            getPostAuth = { postAuth }
+        )
+
+        // Send to an invalid address so the native method returns null rather
+        // than throwing — this is the real-world failure mode that previously
+        // locked the Send button.
+        val tx = TransactionItem(
+            "LhK2kQwiaAvhjWY799cZvMyYwnQAcxkarr",
+            "LOpsAddrInvalid",
+            null,
+            /* sendAmount = */
+            1L,
+            /* opsFee = */
+            0L,
+            null,
+            false,
+            ""
+        )
+
+        val result = sender.prepareTransaction(tx)
+
+        // Either AmountTooSmall or Unknown is acceptable here — what matters is
+        // that isSending is reset and the app is not permanently locked.
+        assertNotNull(result)
+        assertFalse(
+            "isSending must not leak through real-JNI error paths",
+            sender.isSending
+        )
+    }
+
+    @Test
+    fun bwSender_reentrancyGuard_holdsAgainstRealWallet() = runTest {
+        assumeTrue(walletManager.isCreated())
+
+        val postAuth = mockk<PostAuth>(relaxed = true)
+        val sender = BWSender(
+            context = context,
+            getWalletManager = { walletManager },
+            getPostAuth = { postAuth }
+        )
+
+        sender.isSending = true
+        val result = sender.prepareTransaction(buildDummyTx())
+
+        assert(result is BWSendResult.Error.AlreadySending)
+    }
+
+    // -------------------------------------------------------------------------
+    // Balance read — driven through getBalance which is used by SendViewModel
+    // to decide isAmountBelowBalance. A zero/stale read is the "Send stays
+    // disabled" production symptom.
+    // -------------------------------------------------------------------------
+
+    @Test
+    fun getBalance_returnsNonNegativeValue() {
+        val balance = BRWalletManager.getInstance().getBalance(context)
+        assertTrue("Balance must never go negative", balance >= 0)
+    }
+
+    private fun buildDummyTx() = TransactionItem(
+        "LhK2kQwiaAvhjWY799cZvMyYwnQAcxkarr",
+        "LOpsAddr",
+        null,
+        100_000L,
+        500L,
+        null,
+        false,
+        ""
+    )
+}

app/src/androidTest/java/com/brainwallet/wallet/FakeWalletManager.kt

@@ -0,0 +1,9 @@
+package com.brainwallet.wallet
+
+class FakeWalletManager(
+    private val created: Boolean = true,
+    private val addressValid: Boolean = true
+) : WalletManager {
+    override fun isCreated() = created
+    override fun validateAddress(address: String) = addressValid
+}