Skip to content

Feat/bitrefill in topsecret - #217

Merged
kcw-grunt merged 5 commits into
developfrom
feat/bitrefill-in-topsecret
Apr 25, 2026
Merged

kcw-grunt merged 5 commits into
developfrom
feat/bitrefill-in-topsecret

Conversation

@kcw-grunt

@kcw-grunt kcw-grunt commented Apr 25, 2026 •

Copy link
Copy Markdown
Collaborator

📱 Description

This PR integrates Bitrefill gift card purchasing functionality into the Brainwallet app's Shop section. It adds a new "Shop Bento" composable screen displaying Bitrefill gift cards (Visa, Amazon, Just Eat) with animated card layouts, implements a web modal for external Bitrefill integration, and detects user location via phone state to provide region-specific offerings.

🤖 _Auto-generated by GitHub Copilot

Platform

  • Android

🎯 Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🔧 Refactoring (code change that neither fixes a bug nor adds a feature)
  • 📚 Documentation update
  • 🎨 UI/UX improvement
  • ⚡ Performance improvement
  • 🧪 Test addition or improvement

📋 Changes

New Components Added

  • ShopBentoScreen.kt – Main composable displaying the Bitrefill shop bento section with gift card carousel and branding
  • ShopBentoViewModel.kt – MVI ViewModel managing shop state, dark mode, and country detection via TelephonyManager
  • ShopBentoState.kt – Data class holding card data, region data, country ISO, dark mode state, and slide animation flag
  • ShopBentoEvent.kt – Sealed class defining OnLoad and OnTapShop events for the shop ViewModel
  • GiftCardsComposable.kt – Composable managing animated gift card carousel with staggered slide-in animations
  • Cards.kt – Individual card composables (CardVisaComposable, CardAmazonComposable, CardJustEatComposable) with gradient backgrounds and logo overlays
  • WebModalScreen.kt – Generic web view modal for displaying external URLs (Bitrefill, Linktree)
  • ShopBentoViewModelTest.kt – Unit tests for ShopBentoViewModel state management and event handling
  • Drawable assets – logotype_bitrefill_blk.png, logotype_bitrefill_wht.png, amazon_logo.png, visa_logo.png, just_eat_logo.png, store_05.jpg

Modifications

  • AndroidManifest.xml – Added READ_PHONE_STATE permission for country ISO detection via TelephonyManager
  • BWConstants.kt – Added BITREFILL_URL constant with referral link
  • MainNavigationHost.kt – Renamed Route.MoonPayWeb to Route.MoonPayBuy, added new Route.BitrefillWeb and Route.LinktreeWeb composables with WebModalScreen integration
  • Route.kt – Renamed MoonPayWeb to MoonPayBuy, added BitrefillWeb and LinktreeWeb sealed class routes
  • FavouritesBentoScreen.kt – Removed (replaced by ShopBentoScreen functionality)
  • Gradient.kt – Added giftCardGradient1, giftCardGradient2, giftCardGradient3 gradient definitions for gift card styling
  • MainScreen.kt – Updated to include ShopBentoScreen in the main bento layout
  • BentoBottomNavBar.kt – Updated navigation to use new route names
  • Tutorial screens – Minor updates to navigation references
  • strings.xml – Added shop_tagline string resource

Removals

  • FavouritesBentoScreen.kt – Removed; functionality consolidated into ShopBentoScreen as part of the Shop feature redesign

📊 Statistics

  • Additions: 805 lines
  • Deletions: 242 lines
  • Files Changed: 35
  • Commits: 3

🧪 Tests Status

  • Tests ran successfully locally?
  • Added more tests? How many? 1 test file (ShopBentoViewModelTest.kt)

📸 Screenshots/Videos

Action Bitrefill
shop

⚠️ Review Notes

  1. Route Naming – MoonPayWeb → MoonPayBuy rename; confirm all deeplinks/shortcuts are updated
  2. Hard-coded Referral Link – Bitrefill URL contains referral code; consider making configurable if needed for A/B testing
  3. WebModalScreen – Reusable component for external URLs; ensure WebView security settings are appropriate
  4. Dark Mode Handling – ShopBentoViewModel observes settings repo for dark mode; verify theme consistency across all card states

🎯 Reviewers

@kcw-grunt, @josikie


@kcw-grunt
kcw-grunt requested a review from josikie April 25, 2026 22:12
@kcw-grunt kcw-grunt self-assigned this Apr 25, 2026
removed some stale
@kcw-grunt
kcw-grunt force-pushed the feat/bitrefill-in-topsecret branch from 7c5b7f8 to c9a6a34 Compare April 25, 2026 22:35
@gruntsoftware gruntsoftware deleted a comment from github-actions Bot Apr 25, 2026
@kcw-grunt
kcw-grunt merged commit 2af613b into develop Apr 25, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant