Repository navigation
fix: only run auto-translate on push to main/develop, not every PR - #190
Merged
Merged
Conversation
Dropped the pull_request trigger. It re-fired the workflow on every commit pushed to any PR touching Localizable.xcstrings — including long-lived release branches (4 translation PRs spawned against release/v3.9.16-into-main in one afternoon) and the bot's own PR check runs (#188, opened against the '184/merge' ref while #184 was still under review, duplicating #189's content once #184 actually merged). Translations only need generating once a change actually lands on main/develop, not during PR review, so push-only is sufficient and removes the self-duplicating behavior. Also drops the now-dead github.event.pull_request.* fallbacks that existed only to support that trigger. Co-Authored-By: grunt-claude-bot <noreply@grunt.ltd> Co-Authored-By: kcw-grunt <kerry@grunt.ltd>
kcw-grunt
approved these changes
Aug 22, 2026
Collaborator
There was a problem hiding this comment.
On develop or main so its not a noisy call to run
kcw-grunt
added a commit
that referenced
this pull request
Aug 22, 2026
## Highlights since v3.9.16 - Reworked the Buy/Receive sheet (BuyReceiveView) to match the Android app's layout (#177) - Cleared remaining deprecated Security/Foundation API usage and a real infinite-recursion bug (#175) - Reduced the Swift compiler warnings list (#174) - Removed CircleCI — Xcode Cloud is now the sole CI (#173) - Updated Private/bw-gdlib to v1.6.9 (#171) and Modules/core (#176) - Restored the missing translations for COPY NEW ADDRESS, and added translations for BUY / RECEIVE and POWERED BY MOONPAY (21 locales each) — these existed in an earlier release attempt but were never merged back into develop (#184) - Removed 2 dead Localizable.xcstrings keys with no remaining source references: GET LTC, Set amount: (#179) - Fixed the auto-translate script writing Localizable.xcstrings with JSON formatting that didn't match Xcode's String Catalog serializer, which was rewriting every line of the file on every run and producing unreviewable, unmergeable translation PRs (#186) - Fixed the auto-translate workflow re-triggering on every push to any open PR (not just merges to main/develop), which was spawning duplicate translation PRs against long-lived branches (#190) - Picked up 42 additional previously-missing translations across 21 locales, generated cleanly after the above two fixes (#189) - Bumped MARKETING_VERSION to 3.9.17 ## Build CURRENT_PROJECT_VERSION bumped 2602309 -> 2602311. Co-Authored-By: grunt-claude-bot <noreply@grunt.ltd> Co-Authored-By: kcw-grunt <kerry@grunt.ltd>
Closed
kcw-grunt
added a commit
that referenced
this pull request
Aug 22, 2026
## Highlights since v3.9.16 - Reworked the Buy/Receive sheet (BuyReceiveView) to match the Android app's layout (#177) - Cleared remaining deprecated Security/Foundation API usage and a real infinite-recursion bug (#175) - Reduced the Swift compiler warnings list (#174) - Removed CircleCI — Xcode Cloud is now the sole CI (#173) - Updated Private/bw-gdlib to v1.6.9 (#171) and Modules/core (#176) - Restored the missing translations for COPY NEW ADDRESS, and added translations for BUY / RECEIVE and POWERED BY MOONPAY (21 locales each) — these existed in an earlier release attempt but were never merged back into develop (#184) - Removed 2 dead Localizable.xcstrings keys with no remaining source references: GET LTC, Set amount: (#179) - Fixed the auto-translate script writing Localizable.xcstrings with JSON formatting that didn't match Xcode's String Catalog serializer, which was rewriting every line of the file on every run and producing unreviewable, unmergeable translation PRs (#186) - Fixed the auto-translate workflow re-triggering on every push to any open PR (not just merges to main/develop), which was spawning duplicate translation PRs against long-lived branches (#190) - Picked up 42 additional previously-missing translations across 21 locales, generated cleanly after the above two fixes (#189) - Bumped MARKETING_VERSION to 3.9.17 ## Build CURRENT_PROJECT_VERSION bumped 2602309 -> 2602311. Co-Authored-By: grunt-claude-bot <noreply@grunt.ltd> Co-Authored-By: kcw-grunt <kerry@grunt.ltd>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops the
pull_requesttrigger fromauto-translate-ios.yml, keeping onlypush: branches: [main, develop](plusworkflow_dispatch).Why
The
pull_requesttrigger re-fired the workflow on every commit pushed to any PR touchingLocalizable.xcstrings— not just when the change actually landed. That produced duplicate/noisy translation PRs:release/v3.9.16-into-mainin one afternoon (Aug 15), one per push to that long-lived PR184/mergesynthetic check-run ref while Update game and restore COPY NEW ADDRESS translations #184 was still under review, duplicated 🌍 Auto-translations: missing iOS strings updated #189's content once Update game and restore COPY NEW ADDRESS translations #184 actually merged intodevelopTranslations only need generating once a change lands on
main/develop— there's no reason to run it mid-review. Push-only removes both failure modes; direct pushes (merges) still trigger it exactly as intended.Also removes the now-dead
github.event.pull_request.*fallbacks that existed only to support the removed trigger.Companion fix to #186 (JSON formatting), which addressed why each of those runs produced an unreviewable full-file diff instead of a small one.
Co-Authored-By: grunt-claude-bot noreply@grunt.ltd
Co-Authored-By: kcw-grunt kerry@grunt.ltd
🤖 Generated with Claude Code