Skip to content

Remove ancient unused pre-processor definitions (2/4) - #822

Merged
gwsw merged 6 commits into
gwsw:masterfrom
ralish:shared-fixes
Sep 26, 2026
Merged

gwsw merged 6 commits into
gwsw:masterfrom
ralish:shared-fixes

Conversation

@ralish

@ralish ralish commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

This PR removes three pre-processor definitions which are no longer in use:

  • HAVE_ANSI_PROTOS
  • HAVE_WCTYPE_H / HAVE_WCTYPE
  • HAVE_VOID

Further details are available in each commit description. This PR is based on top of PR #821.

@ralish
ralish marked this pull request as ready for review September 2, 2026 03:22
This is a superset of the previous ignored globs. The existing entries
are now categorised, and the following additional globs are ignored:

- lessmsg.inc
  Automatically generated by distfiles make target
- *.exe
  Executables on DOS, OS/2, and Windows systems
- *.obj
  Object files for some DOS, OS/2, and Windows compilers
- *.bak, *.log, *.tmp
  Backup, log, and temporary files
Shell scripts should always use LF line endings, even on platforms that
typically use a different end-of-line sequence (e.g. CRLF on Windows).
This commit ensures the files are checked-out with LF line endings even
on platforms for which the default end-of-line sequence is different.
For authors which have committed to the repository under multiple
identities, this instructs Git as to the canonical identity and ensures
commits are attributed to that identity. Also useful with `git shortlog`
when displaying a summary of Git authors and associated commit counts.
Appears to be a relic from when less supported pre-ANSI C and had to
choose between `void *` and `char *`.
Another apparent relic from when less supported pre-ANSI C and supported
K&R-compatible prototype macros.
Appears to be for planned but never implemented wide-character support.
It's never enabled anywhere, and if it were it only enables some (now
removed) upper/lower to/is macros. Even that's not true as those macros
are gated by `HAVE_WCTYPE` (no `_H` suffix) which isn't defined.
@gwsw
gwsw merged commit 66bded9 into gwsw:master Sep 26, 2026
@ralish
ralish deleted the shared-fixes branch September 27, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants