Repository navigation
Refactor Phase 6: CI - #59
Merged
Merged
Conversation
…ports docker-compose.test.yml (postgres:17-alpine :5433, redis:8-alpine :6380); jest-integration.json (30s timeout, setupFiles env); setup.ts (AppModule + PORTS fakes, main.ts pipeline mirror, truncate helper); health/validation-envelope/pricing suites; test:integration(+:db) scripts; unit testPathIgnorePatterns. Also fixes 5 baseUrl-only 'src/...' imports to relative (auth module/decorators/types) — they resolved at build but never under Jest. Verified: 3 suites / 4 tests green against real services, tsc 0.
…ge artifact Unit job keeps only NODE_ENV=test (14 leaked secrets removed; all unit specs are fully mocked). New integration job (postgres:17 + redis:8 services, dummy non-secret env, ports faked in-suite) runs db push + jest-integration. Build now needs integration and stays master-push-only. Coverage report uploaded as artifact. tsc gate added; lint gate deliberately omitted (pre-existing repo-wide CRLF debt — documented in-file).
Retires the default Hello World! scaffold; boots the full AppModule (ports faked, main.ts pipeline mirrored) against the integration compose stack. 30s timeout + shared env-setup. CI runs it after the integration suite in the same job. Verified: 3 suites / 3 tests green, tsc 0, eslint 0 errors.
entrypoint.sh no longer seeds on boot (SEED_ON_BOOT, default false); new .env.example documents every validated key with code-accurate defaults (un-ignored via negation); pragmatic global coverageThreshold 90/70/85/90 — current 91.9/73.6/87.2/91.9 clears it (strict 100/95 deferred: trip/health/user gaps + controller decorator-branch artifact, see REFACTOR.md).
REFACTOR.md covers Phases 1-6 (previous state, considerations, changes per area), the frontend migration digest (2.x-5.x, replacing docs/BREAKING-CHANGES.md), a before/after summary matrix, and documented deviations (pragmatic gate, slim integration matrix, 404 body shape, CRLF lint debt). README keeps its structure: corrected token lifetimes, pricing numbers, and env defaults to code values; added missing env keys, upload size note, /api prefix, and the three testing tiers.
Working phase docs were gitignored/untracked; their substance (breaking-changes digest, audit disposition, per-phase record) now lives in REFACTOR.md. Drops the stale /docs ignore rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.