Skip to content

docs: rewrite CONTRIBUTING.md for the Rust CLI (Fixes #12) - #23

Open
domfelipe wants to merge 4 commits into
hanzoai:mainfrom
domfelipe:bounty/cli-12-contributing
Open

domfelipe wants to merge 4 commits into
hanzoai:mainfrom
domfelipe:bounty/cli-12-contributing

Conversation

@domfelipe

Copy link
Copy Markdown

Claiming — Fixes #12.

Replaces the Python-era CONTRIBUTING.md (241 lines, Dev-AI/dev clone URL, venv/pip/pytest/Black/isort, dead dev.chat links) with a 73-line Rust-focused guide: clone hanzoai/cli, cargo build / cargo test / cargo clippy --bin hanzo, single-test commands, test locations (tests/cli.rs, inline unit tests, src/commands/product/tests.rs, crates/client/tests/contract.rs), PR process.

Acceptance check:

  • grep for pip/pytest/venv/black/isort/Dev-AI/dev.chat: clean (exit 1).
  • All 3 URLs return 200 (github.com/hanzoai/cli, .../issues, contributor-covenant.org).
  • File is shorter (73 < 241 lines).
  • cargo test --no-run compiles.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-31T13:31:37.438766Z
We couldn’t complete this review. Comment @codex review to try again.
9fb3607 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@domfelipe

Copy link
Copy Markdown
Author

Validation note: the repo's CI/CD only runs on hanzo.ai self-hosted runners, so fork PRs show action_required (queued, no GitHub-hosted runner picks them up) — same status as the other open PRs here. Verified locally instead:

  • cargo test --no-run compiles cleanly (all test targets build, incl. cloud_sessions, production, spec_drift)
  • All 3 URLs in the rewritten CONTRIBUTING.md return HTTP 200; no Python references or dead links remain (grep clean)

@domfelipe

Copy link
Copy Markdown
Author

Rebased onto main (was 25 commits behind) — merged cleanly, no conflicts (CONTRIBUTING.md itself was untouched upstream, so the rewrite still applies as-is).

Re-validated after the merge against the issue's acceptance criteria:

  • grep -n -i -e pip -e pytest -e venv -e black -e isort -e Dev-AI -e dev.chat CONTRIBUTING.md → prints nothing
  • All URLs in the file return 200 (curl -sIL): github.com/hanzoai/cli, github.com/hanzoai/cli/issues, contributor-covenant.org
  • File is 73 lines (was 241)
  • cargo build → exit 0 on the merged tree

Fork CI remains action_required because the workflows run on the self-hosted hanzo.ai runners; the local runs above are the equivalent check.

@domfelipe

Copy link
Copy Markdown
Author

Kept this branch current — merged main again (18 commits since the last sync, zero conflicts; CONTRIBUTING.md is still untouched upstream).

Re-validated against the issue's acceptance criteria on the merged tree:

  • grep -n -i -e pip -e pytest -e venv -e black -e isort -e Dev-AI -e dev.chat CONTRIBUTING.md → prints nothing
  • 73 lines (was 241)
  • cargo build → exit 0

Fork CI still shows action_required (workflows target the self-hosted hanzo.ai runners), so those local runs are the equivalent check.

@domfelipe

Copy link
Copy Markdown
Author

Synced with main again (b656e1c2, 4 new upstream commits since the last sync — release 8.5.914, machine-key spec pin). No conflicts.

Re-validated after the merge: CONTRIBUTING.md is still the 73-line Rust-CLI rewrite, the grep for obsolete stack references (pip/pytest/venv/aider/Dev-AI) returns nothing, and cargo build succeeds.

For reference, upstream CONTRIBUTING.md on main is still the 241-line Python/aider text this PR replaces, so the issue is still open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewrite CONTRIBUTING.md for the Rust CLI; it describes a Python app

1 participant