Repository navigation
test(auth): ask a reopened port, do not count it - #46
Merged
Merged
Conversation
finish_answers_the_tab_and_its_retry_then_closes_the_port asserted that a connect to the freed loopback port is refused. The kernel hands that port out again and the binary's other tests bind loopback ports in parallel, so it failed on main (run 42322666479) with nothing wrong in finish. A connection that opens is now asked, and must not be answered with the signed-in page. Co-authored-by: Hanzo Dev <dev@hanzo.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finish_answers_the_tab_and_its_retry_then_closes_the_portasserted that a connect to the freed loopback port is refused. The kernel hands that port out again and this binary's other tests bind loopback ports in parallel, so main went red on run 42322666479 with nothing wrong infinish(the re-run passed).A connection that opens is now asked, and must not be answered with the signed-in page — the property the test is about. Test-only; no version change.