Repository navigation
Fix editor diff gutter layout and Inbox PR overview diff colors - #758
Closed
EricRasputin wants to merge 2 commits into
Closed
EricRasputin wants to merge 2 commits into
EricRasputin wants to merge 2 commits into
Conversation
hardbeat920#707 put the +/- glyph in the editor's git gutter, which is the leftmost gutter, so the marker sat two columns away from its line with a color bar on each side of the line numbers. The glyph gutter now registers at low precedence so it lands next to the code, and diff tabs list the fold gutter before the line numbers. Changed rows tint their gutter cells, removed lines show their old line number, and the two color bars are gone, matching the unified diff view. The number gutter reserves room for the original file's widest line number so old numbers don't clip or shift the gutter while scrolling. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The pull request overview card still used hardcoded emerald and red for its total and per-file change counts and for the per-file added/removed bar, so it ignored the Diff colors palette added in hardbeat920#707. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
+/−marker sits between the line numbers and the code instead of at the far left of the gutter. Changed rows tint their line numbers, removed lines show their old line number, and the two color bars per line are gone, so it matches the unified diff view.+N -N, and the per-file bar) uses the diff color tokens, so it follows the selected Diff colors palette.Why
Follow-up to #707, which shipped in 0.7.1. That PR was only checked in the unified diff view. In the editor diff it reused the git gutter, which is the leftmost one, so the marker ended up two columns away from its line, with a color bar on each side of the untinted line numbers. The Inbox PR overview was the one diff surface still on hardcoded emerald/red.
UI
Before
After
Both are the same file, rendered from the real editor extensions and app CSS in headless Chromium (dark theme, Default palette). No screenshot of the Inbox overview; it is a class swap to the existing tokens.
Notes for review
editorGitregisters its marker gutter at low precedence so it lands next to the code, andFileEditorlistsfoldGutter()beforelineNumbers()in diff tabs.Checklist
npm run check