FE-1515: Give sidebar list labels the full row width until the row menu shows - #9377
Conversation
Rows revealed their action button by animating opacity, so the hidden button always reserved its layout space: lists with row menus wrapped labels earlier than lists without, and the space was wasted until hover. The button is now hidden with display, so labels take the full row width and only shrink while the row is hovered or its menu is open. Item content rendered as nested lines (a name with a subtitle) escaped the row's ellipsis and clipped hard; nested lines now truncate the same way plain-text items do.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
PR SummaryLow Risk Overview Label truncation is tightened: the name cell gets Includes a patch changeset for Reviewed by Cursor Bugbot for commit b2b708e. Bugbot is set up for automated code reviews on this repo. Configure here. |
🌟 What is the purpose of this PR?
Left-sidebar list items cropped inconsistently. Rows with a row menu always reserved space for the hidden "More options" button (it was revealed by animating opacity, which keeps its layout size), so those lists wrapped labels ~20px early — while lists without menus used the full width. And items rendering a name with a subtitle (e.g. parameters) escaped the row's ellipsis and clipped hard, while plain-text items showed "…".
Labels now take the full row width with a consistent ellipsis, and only shrink while the row is hovered (or its menu is open), when the button actually appears.
Before — space reserved for the hidden button, and name/subtitle lines hard-clip without an ellipsis:
After — full-width labels, consistent "…" truncation (same net, same 200px sidebar):
🔗 Related links
🚫 Blocked by
claude/fe-1512-adaptive-bezier-label-midpoint; only the last commit belongs to this PR until the stack below merges.🔍 What does this change?
filterable-list-sub-view.tsxhides[data-row-action]withdisplay: noneinstead ofopacity: 0, revealing it on row hover or while its menu is open — the hidden button no longer occupies layout.listItemNameStyleapplies its truncation (nowrap, hidden overflow, ellipsis) to nested item lines as well, so name + subtitle renderers truncate like plain-text ones.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
The user guide does not describe row-menu reveal behaviour.
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
displaycannot transition, so the button appears instantly. A@starting-stylefade can be added later if the pop feels abrupt.display: none). Previously it was tab-focusable but invisible, which was not meaningfully more accessible.🛡 What tests cover this?
display: noneby default and the label content spans the full row (244px of a 256px row); forcing the menu-open state (the same rule as:hover) shows the 20px button and shrinks the content to 224px; nested name and<pre>subtitle lines computenowrap/ellipsis/hidden.❓ How to test this?
yarn workspace @hashintel/petrinaut dev, open a story with parameters (e.g.Handle Spike With Sir), narrow the left sidebar.🤖 Generated with Claude Code