Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## bm/be-851-atlas-remove-the-single-generation-serving-layer #9706 +/- ##
==============================================================================================
+ Coverage 65.71% 71.13% +5.41%
==============================================================================================
Files 1712 1308 -404
Lines 182323 134980 -47343
Branches 7529 5835 -1694
==============================================================================================
- Hits 119816 96017 -23799
+ Misses 61086 37854 -23232
+ Partials 1421 1109 -312
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
as_constant |
< 1 ns | < 1 ns | N/A | |
constant_equal |
< 1 ns | < 1 ns | N/A | |
constant_not_equal |
< 1 ns | < 1 ns | N/A | |
access |
< 1 ns | < 1 ns | N/A | |
runtime_equal |
< 1 ns | < 1 ns | N/A | |
runtime_not_equal |
< 1 ns | < 1 ns | N/A |
Comparing bm/be-856-atlas-rewrite-the-crate-documentation (bfa3985) with bm/be-851-atlas-remove-the-single-generation-serving-layer (a845aa4)
Footnotes
-
18 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
28bb8fa to
7a633bf
Compare
7a633bf to
768e37d
Compare
768e37d to
ec59699
Compare
PR SummaryLow Risk Overview Module and item docs gain Errors and Panics sections where fallible or panicking APIs lacked them. First-use intra-doc links tie crate terms to their definitions; in-crate examples on private types are marked Prose in Reviewed by Cursor Bugbot for commit bfa3985. Bugbot is set up for automated code reviews on this repo. Configure here. |
ec59699 to
bfa3985
Compare
🌟 What is the purpose of this PR?
Rewrite the atlas crate's documentation so that it states contracts instead of narrating motives. The documentation across the crate describes component roles and design intent and leaves the contracts unstated. Few fallible functions carry an errors section or a panics section, and crate terms appear as bare words a reader has to guess at. After this change a reader in a diff hunk sees what an item is, what it returns on failure, when it panics, and a link on the first use of every crate term.
For review, the properties this stands on:
cargo docbuilds with every intra-doc link resolving.Comment lines, plus twelve
#[expect(rustdoc::broken_intra_doc_links)]attributes on links whose targets arrive in later changes. Each attribute leaves with the change that adds its target, and no code moves.🔍 What does this change?
src/, the five bench targets underbenches/, and theIdSlicedoc inlibs/@local/hashql/core/src/id/slice.rs.ignoreand says why.❓ How to test this?
RUSTDOCFLAGS='-D warnings' cargo doc -p hash-graph-atlas --no-deps --all-featuresbuilds.lib.rsand follow one module down to its items. Every linked term resolves and every fallible function has an errors section.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR: