Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## bm/be-845-atlas-world-epoch-and-schedules-of-the-serving-layer #9710 +/- ##
==================================================================================================
+ Coverage 68.72% 68.84% +0.12%
==================================================================================================
Files 1114 1121 +7
Lines 101466 102550 +1084
Branches 5000 5073 +73
==================================================================================================
+ Hits 69729 70602 +873
- Misses 30888 31079 +191
- Partials 849 869 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3dd45c1 to
3177d2c
Compare
3177d2c to
5f1e185
Compare
5f1e185 to
91767d7
Compare
PR SummaryMedium Risk Overview
Extensive unit tests cover pending/feed/placement/projector edge cases. Unrelated test fixtures in Reviewed by Cursor Bugbot for commit c999864. Bugbot is set up for automated code reviews on this repo. Configure here. |
no more Bilal, we are Mustermaxxing now.
91767d7 to
c999864
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c999864. Configure here.
| else { | ||
| return true; | ||
| }; | ||
| delta.update_edge(entity, legend.clone(), Some([source, target])) |
There was a problem hiding this comment.
Type change keeps both identities live
Medium Severity
apply writes a node or edge from the latest classification without withdrawing the other identity. After an entity's type flips between link and non-link, classify follows the new kind, and both the old row and the new one stay visible in the published overlay.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit c999864. Configure here.


🌟 What is the purpose of this PR?
Add the delta pipeline that keeps a generation's overlay live, from the feed through placement and projection to the task that runs them. A delta feed bound to one process-wide atlas and a single epoch cannot run per generation, and a second generation has no feed of its own. Here a generation's feed runs against its own
World, and each published revision is a newEpoch.The module stays dead code under the
lib.rsattribute until the read API consumes it (BE-815).For review, the properties this stands on:
Epoch.🔍 What does this change?
serve/delta/feed/:DeltaReaderand the pending queue.serve/delta/placement/:DeltaPlacementTaskand its pending set.serve/delta/projector/:DeltaProjectorover theEmbeddingWorkflow.serve/delta/task/:DeltaTaskwith its options, the lifecycle that runs the three and publishes.serve/walk/:Walkover a captured schedule.❓ How to test this?
cargo nextest run -p hash-graph-atlas --all-features serve::delta::runs the feed, placement, projector and task tests, including the start, stop and join cases.serve/delta/task/mod.rsis the lifecycle, and the other three are what it drives.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR: