FE-1718: Polish experiment creation, results, and optimizer controls

.changeset/ad-hoc-value-errors.md

@@ -0,0 +1,5 @@
+---
+"@hashintel/petrinaut": patch
+---
+
+Improve scenario and experiment forms with keyboard navigation, stacked section headers, overlay scrollbars, default starting-place filtering with a compact toggle beside the section title, and source expressions over selected computed values. Align the Time Step label and info icon, align token totals with place headers, keep select chevrons inside spreadsheet cells, and keep validation errors visible while editing ad-hoc values.

.changeset/editable-example-scenarios.md

@@ -0,0 +1,5 @@
+---
+"@hashintel/petrinaut-core": patch
+---
+
+Make bundled example scenarios editable in the ad-hoc scenario form while preserving their parameters and initial states.

.changeset/experiment-interval-feedback.md

@@ -0,0 +1,5 @@
+---
+"@hashintel/petrinaut": patch
+---
+
+Offer GPU compute, parameter sweeps, and in-browser optimization without feature flags, with automatic metric names, grouped constraints that accept state expressions, keyboard controls, and explicit optimizer startup. Simplify results with manual optimizer controls, compact details, single-value parameter sliders, sensitivity estimates ordered by importance, and best parameters that remain available after optimization with a View best action.

.changeset/experiment-settings-guide.md

@@ -0,0 +1,5 @@
+---
+"@hashintel/petrinaut-core": patch
+---
+
+Accept state constraint expressions with optional trailing semicolons and no explicit return while preserving existing code bodies. Report a missing return when a state constraint contains separate statements. Update the assistant's guide summaries for experiment controls and settings available without simulation feature flags.

apps/petrinaut-website/README.md

@@ -118,9 +118,7 @@ use provider-pattern discovery instead.
 The demo at [http://localhost:5173](http://localhost:5173) runs the optimizer
 in the browser: the Optuna study runs in a Pyodide web worker and each
 optimization step runs on Petrinaut's own experiments backend, so no Python
-service is involved. With the experimental **Parameter sweeps** and
-**In-browser optimization** settings on, under **Viewport controls > Settings >
-Simulation**, a sweep's Parameters card in the Experiments tab offers
+service is involved. A sweep's Parameters card in the Experiments tab offers
 **Optimize**. The first optimization in a browser downloads the Python runtime
 from jsDelivr and Optuna from PyPI; later runs use the browser cache.
 

apps/petrinaut-website/scripts/generate-example-artifacts.ts

@@ -65,9 +65,12 @@ const generateRuntime = async (entry: ExampleCatalogEntry) => {
     null,
   ) as Record<string, ScenarioHir>;
   for (const scenario of definition.scenarios ?? []) {
-    const hir = lowerScenarioToHir({
-      parameterOverrides: scenario.parameterOverrides,
-      initialState: scenario.initialState,
+    const hir = lowerScenarioToHir(scenario, {
+      adHocContext: {
+        places: definition.places,
+        types: definition.types,
+        netParameters: definition.parameters,
+      },
     });
     const outcome = compileScenario(
       scenario,

apps/petrinaut-website/src/examples/catalog.test.ts

@@ -1,5 +1,7 @@
 import { describe, expect, it } from "vitest";
 
+import { compileScenario } from "@hashintel/petrinaut-core";
+
 import {
   exampleCatalog,
   exampleSlugs,
@@ -34,7 +36,16 @@ describe("example catalog", () => {
       expect(example.catalog).toBe(entry);
 
       for (const scenario of example.definition.scenarios ?? []) {
+        expect(scenario.initialState.type).toBe("adhoc");
         expect(runtime.scenarioHirById).toHaveProperty(scenario.id);
+        const compiled = compileScenario(
+          scenario,
+          runtime.scenarioHirById[scenario.id]!,
+          example.definition.parameters,
+          example.definition.places,
+          example.definition.types,
+        );
+        expect(compiled.ok, JSON.stringify(compiled)).toBe(true);
 
         for (const parameter of scenario.scenarioParameters) {
           const bounds = entry.parameterBounds[parameter.identifier];

apps/petrinaut-website/src/examples/example-search.test.ts

@@ -82,6 +82,12 @@ describe("example search contract", () => {
         settings: "unknown",
       }).settings,
     ).toBeUndefined();
+    expect(
+      validateSharedExampleSearch({
+        overlay: "user-settings",
+        settings: "simulation",
+      }),
+    ).toMatchObject({ overlay: "user-settings", settings: undefined });
     expect(
       validateSharedExampleSearch({
         overlay: "create-experiment",

apps/petrinaut-website/src/examples/example-search.ts

@@ -40,12 +40,7 @@ export const sharedOverlays = [
   "create-experiment",
 ] as const;
 
-export const sharedSettingsSections = [
-  "general",
-  "viewport",
-  "simulation",
-  "labs",
-] as const;
+export const sharedSettingsSections = ["general", "viewport", "labs"] as const;
 
 export const sharedResourceTypes = [
   "scenario",

apps/petrinaut-website/src/examples/models/gases-1-pn-consumption-trigger.json

@@ -430,8 +430,125 @@
         "param__draw_enabled": "scenario.draw_enabled"
       },
       "initialState": {
-        "type": "code",
-        "content": "return {\n  IdleTankers: 1,\n  LoadsDelivered: 0,\n  SteadyNitrogenOrderPlaced: 0,\n  SteadyNitrogenOrderPermits: 2,\n  SteadyNitrogenOnRoute: 0,\n  SteadyNitrogenVented: 0,\n  SteadyNitrogenLineRunning: 1,\n  SteadyNitrogenLineStopped: 0,\n  SteadyNitrogenStockouts: 0,\n  SteadyNitrogenConsumed: 0,\n  SteadyNitrogenEvaporated: 0,\n  SteadyNitrogenContents: 42,\n  SteadyNitrogenUllage: 12,\n  SteadyNitrogenUnitsDrawnSinceOrder: 0,\n};"
+        "type": "adhoc",
+        "content": {
+          "variables": [
+            {
+              "name": "draw_enabled",
+              "type": "real",
+              "expression": "1",
+              "exposed": true,
+              "optimize": null
+            }
+          ],
+          "netParameters": [
+            {
+              "parameterId": "param__draw_enabled",
+              "expression": "scenario.draw_enabled",
+              "optimize": null
+            }
+          ],
+          "places": {
+            "place__idle_tankers": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "1",
+                "optimize": null
+              }
+            },
+            "place__loads_delivered": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            },
+            "place__s1_order_placed": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            },
+            "place__s1_order_permits": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "2",
+                "optimize": null
+              }
+            },
+            "place__s1_on_route": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            },
+            "place__s1_vented": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            },
+            "place__s1_line_running": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "1",
+                "optimize": null
+              }
+            },
+            "place__s1_line_stopped": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            },
+            "place__s1_stockouts": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            },
+            "place__s1_consumed": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            },
+            "place__s1_evaporated": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            },
+            "place__s1_contents": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "42",
+                "optimize": null
+              }
+            },
+            "place__s1_ullage": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "12",
+                "optimize": null
+              }
+            },
+            "place__s1_units_drawn_since_order": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            }
+          }
+        }
       }
     },
     {
@@ -449,8 +566,125 @@
         "param__draw_enabled": "scenario.draw_enabled"
       },
       "initialState": {
-        "type": "code",
-        "content": "return {\n  IdleTankers: 1,\n  LoadsDelivered: 0,\n  SteadyNitrogenOrderPlaced: 0,\n  SteadyNitrogenOrderPermits: 2,\n  SteadyNitrogenOnRoute: 0,\n  SteadyNitrogenVented: 0,\n  SteadyNitrogenLineRunning: 1,\n  SteadyNitrogenLineStopped: 0,\n  SteadyNitrogenStockouts: 0,\n  SteadyNitrogenConsumed: 0,\n  SteadyNitrogenEvaporated: 0,\n  SteadyNitrogenContents: 42,\n  SteadyNitrogenUllage: 12,\n  SteadyNitrogenUnitsDrawnSinceOrder: 0,\n};"
+        "type": "adhoc",
+        "content": {
+          "variables": [
+            {
+              "name": "draw_enabled",
+              "type": "real",
+              "expression": "0",
+              "exposed": true,
+              "optimize": null
+            }
+          ],
+          "netParameters": [
+            {
+              "parameterId": "param__draw_enabled",
+              "expression": "scenario.draw_enabled",
+              "optimize": null
+            }
+          ],
+          "places": {
+            "place__idle_tankers": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "1",
+                "optimize": null
+              }
+            },
+            "place__loads_delivered": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            },
+            "place__s1_order_placed": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            },
+            "place__s1_order_permits": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "2",
+                "optimize": null
+              }
+            },
+            "place__s1_on_route": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            },
+            "place__s1_vented": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            },
+            "place__s1_line_running": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "1",
+                "optimize": null
+              }
+            },
+            "place__s1_line_stopped": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            },
+            "place__s1_stockouts": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            },
+            "place__s1_consumed": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            },
+            "place__s1_evaporated": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            },
+            "place__s1_contents": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "42",
+                "optimize": null
+              }
+            },
+            "place__s1_ullage": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "12",
+                "optimize": null
+              }
+            },
+            "place__s1_units_drawn_since_order": {
+              "kind": "uncoloured",
+              "count": {
+                "expression": "0",
+                "optimize": null
+              }
+            }
+          }
+        }
       }
     }
   ],