FE-1833: Speak progress while Brunch works - #9889
kostandinang wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
PR SummaryMedium Risk Overview
The demo wires approval pending state from Reviewed by Cursor Bugbot for commit 18488e5. Bugbot is set up for automated code reviews on this repo. Configure here. |
9373ca4 to
e215dfa
Compare
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
0d4928a to
18488e5
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 18488e5. Configure here.
| result.status === "accepted" && | ||
| result.startMs !== undefined | ||
| ) { | ||
| captions.progress(result.startMs); |
There was a problem hiding this comment.
Progress send failures warn as answers
Medium Severity
Progress lines are sent as commentary with a null delegation, but append failures still use the existing commentary warning that calls the payload an answer. A refused progress send can surface that warning while Brunch is still working and the wrap-up has not been attempted.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 18488e5. Configure here.


🌟 What is the purpose of this PR?
Let Brunch say a short progress line during long Live voice turns, while staying silent through quick answers and fast tool bursts.
🔗 Related links
🚫 Blocked by
main.🔍 What does this change?
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
📜 Does this require a change to the docs?
🕸️ Does this require a change to the Turbo Graph?
The recording exposed a final-caption mismatch: part of the acknowledgement appears in the written summary but not its audio. Live also added “I'm” to the second progress line. The model build was blocked by browser-tool lease failures.
🐾 Next steps
Fix the caption mismatch, verify a successful model-building turn, and finish the voice docs before marking ready.
🛡 What tests cover this?
❓ How to test this?
PETRINAUT_OPENAI_VOICE_ENABLED=true PETRINAUT_VOICE_PROVIDER=live yarn dev:brunch. Open/newon port 4915.[Petrinaut Live trace]logs. Progress should be audible only on long turns, leave the request open, and neither overlap the summary nor appear in written history.📹 Demo
progress-demo.mp4
Click to play with sound. Real Live session, 70 seconds with long pauses trimmed: first progress at 0:28, second at 0:39, final response at 0:48. The final response reports the failed model build; this is not a successful-build demo.