Repository navigation
FE-1828: Add interview length controls to Brunch #9894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kostandinang
wants to merge
46
commits into
main
Choose a base branch
from
ka/fe-1828-interview-budget
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,141
β243
Open
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
195739f
Respect per-turn interview question budgets in Brunch
kostandinang 6c288e7
Add interview budget controls to Chat and Voice
kostandinang 4585e20
Match the interview budget control to its prototype
kostandinang 174376c
Remove divider above the interview budget description
kostandinang 00ba547
Reserve the interview budget status row to avoid layout shift
kostandinang aa101ab
Shorten interview budget copy in the popover, estimate card and transβ¦
kostandinang 6c4a5a0
Return focus to the interview budget trigger after Escape
kostandinang 1d95818
Keep budget notes made while Brunch is replying
kostandinang 6120e86
Simplify interview level notes in the chat transcript
kostandinang f6e634e
Refine interview level notes and preserve blank dock status space
kostandinang 0d64b87
Remove redundant wording from Off transcript notes
kostandinang b73b98f
Remove the selected interview level underline
kostandinang fb29464
Restore the compact Voice dock height
kostandinang 68b1d80
Rename the interview control to Conversation depth
kostandinang 3cc0a8f
Simplify the interview control label to Detail level
kostandinang 377d149
Label the interview control Interview length
kostandinang 76c58b4
Simplify interview length descriptions
kostandinang 17664c3
Gate interview length behind Brunch Labs
kostandinang ed2e2d0
Move interview length to the leading composer edge
kostandinang ae12bda
Clarify interview length descriptions and progress copy
kostandinang b64d924
Clarify interview length feedback and accessible context
kostandinang 8f29c5f
Use the Interview length term in model instructions and skill guidance
kostandinang 517d818
Fix canonical interview counting and Live pacing acknowledgement
kostandinang 1be64e3
Carry interview length as opaque submission context
kostandinang 1e1e88b
Move the interview length guide to the website docs
kostandinang 8ab6070
Describe only the generic assistant slots in the changeset
kostandinang 4a8dbfd
Keep host feature wording out of the assistant system-note default anβ¦
kostandinang 14a024d
Treat a reply that absorbed a closing answer as the interview wrap-up
kostandinang 0cbadd4
Keep following a streaming reply beneath a trailing system note
kostandinang e3753f2
Count host questions asked before a joined closing answer
kostandinang 81ec80f
Merge branch 'main' into ka/fe-1828-interview-budget
kostandinang fd4eb54
Budget Brunch replies by the panel's input mode, matching the estimate
kostandinang ff1d17b
Merge remote-tracking branch 'origin/main' into ka/fe-1828-interview-β¦
kostandinang 0d56c27
Match the reworded Live answer warning in the pacing test
kostandinang b25edb6
Merge remote-tracking branch 'origin/main' into ka/fe-1828-interview-β¦
kostandinang e5b0e4f
Remove the sweep output schema left unused by the transport
kostandinang b3742bc
Move the interview length preference out of the Voice preference module
kostandinang 55b259e
Derive interview length stop positions from the number of levels
kostandinang 8a3fc4b
Check the submitted interview allowance against the plugin's type
kostandinang 284e2ab
Show Last question until the final answer, then Wrapping up
kostandinang 2fa0261
Pass Live append options by name instead of position
kostandinang e6a3f83
Compute interview length note positions with one helper
kostandinang cd5410c
Drop an assertion about retired interview length copy
kostandinang be747d1
Keep submission context out of the Brunch model's view of user turns
kostandinang dacbbdb
Merge remote-tracking branch 'origin/main' into ka/fe-1828-interview-β¦
kostandinang 29c9198
Merge remote-tracking branch 'origin/main' into ka/fe-1828-interview-β¦
kostandinang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@hashintel/petrinaut": patch | ||
| --- | ||
|
|
||
| Add `renderComposerStatus` for host-owned status above the composer or expanded Voice dock, without changing the collapsed dock's height, and `renderSystemMessage` for host-owned system-note content. Pass the current `inputMode` to composer controls, keep composer controls available in the live Voice dock, and display system messages as visible notes in Chat and Voice. With `presentation: "brunch"`, composer controls sit at the leading edge of the composer and Voice dock, separate from submission and session actions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Interview length | ||
|
|
||
| On the Petrinaut website, open **User settings β Labs**, select **Use Brunch**, and enable **Interview length**. This experiment starts disabled: no length control or estimate appears, and Brunch uses its ordinary interview behaviour. Turning it off preserves your saved level for next time. | ||
|
|
||
| ## Choose a length | ||
|
|
||
| When enabled, the round icon at the left of the message input opens **Interview length** above it. Send or Voice stays at the right. The same control appears at the left of the Voice dock without increasing its height. Choose **Off**, **Quick Β· ~5 min**, **Standard Β· ~10 min** (the default), **Thorough Β· ~20 min**, or **Deep Β· no limit**. Click a stop name, drag the rail, or focus it and use the arrow keys. The browser remembers the level and whether the experiment is enabled. | ||
|
|
||
| ## Follow the estimate | ||
|
|
||
| After the first reply, a quiet status sits at the right above the composer or Voice controls in the expanded conversation. It estimates time from questions left; it is not a countdown. The row stays blank before the first reply and when Off is selected, but keeps its space so the input controls do not move. The collapsed Voice dock omits this row entirely to stay compact; expand the conversation to see the estimate. Hover or focus the estimate for a card with the question count and closing behaviour. | ||
|
|
||
| Quick, Standard and Thorough allow respectively 3, 6 and 10 replies in text, or 2, 4 and 7 in Voice. Each Brunch reply counts as one question, including a grouped question or a confirmation-only reply. The estimate progresses to **1 question left**, then **Last question** while Brunch's final question awaits your answer, then **Wrapping up** once you have answered it. These labels reflect the count and your submissions, not whether Brunch is currently speaking or the model is complete. Deep shows the running count and offers pauses between topics; Off uses Brunch's usual pacing. | ||
|
|
||
| ## Change the length or reach the cap | ||
|
|
||
| Changing the level adds a compact note with the level's icon and colour, such as **Quick Β· ~5 min**, to this session's transcript. It appears with a brief, subtle animation unless reduced motion is enabled. Earlier questions still count towards the new cap; Brunch applies the change on the next submission. | ||
|
|
||
| At the cap, Brunch records the latest answer and closes with stated facts, labelled assumptions and open items. A cap does not mean the model is complete or runnable: missing facts, ranges and units remain open rather than being invented. You can choose a higher level to continue. The closing summary does not use another question: raising Standard to Thorough after six text replies and their wrap-up leaves four questions, including after reloading. | ||
|
|
||
| ## Voice | ||
|
|
||
| Live adjusts its voice pacing quietly when you change the level. If that update fails, a warning appears without interrupting speech; choose another length to try again. Brunch's question limit still applies independently of Live's pacing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.