Skip to content

SRE-1121: Add new codeowners, fix license matching and specificity ordering - #9900

Merged
CiaranMn merged 2 commits into
mainfrom
cm/update-codeowners
Oct 2, 2026
Merged

CiaranMn merged 2 commits into
mainfrom
cm/update-codeowners

Conversation

@CiaranMn

@CiaranMn CiaranMn commented Oct 2, 2026

Copy link
Copy Markdown
Member

🌟 Purpose

To ensure the right people approve changes to certain files/folders, this PR does the following:

  1. Adds ownership of design system-related changes to a newly created design-system team
  2. Same for petrinaut
  3. Assigns existing backend team as owner of the Node API and core Graph packages.

It also fixes existing issues:

  1. LICENSE matching: the existing patterns missed e.g. LICENSE-MIT.md. The PR replaces the existing duplicative patterns with LICENSE* (matching is case sensitive so this won't match e.g. license.svg).
  2. The codeowner logic is 'last matched wins', so previously any license files in e.g. /libs/@local/graph/postgres-store/postgres_migrations/ would have not needed legal approval (as the legal ownership was overridden by the later backend ownership). The PR moves the most specific rules (e.g. turbo.json) to the bottom.

@CiaranMn
CiaranMn requested a review from a team as a code owner October 2, 2026 15:52
@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
petrinaut Ready Ready Preview Oct 2, 2026 4:08pm UTC
3 Skipped Deployments
Project Deployment Actions Updated
hash Ignored Ignored Preview Oct 2, 2026 4:08pm UTC
hashdotdesign-tokens Ignored Ignored Preview Oct 2, 2026 4:08pm UTC
petrinaut-docs Ignored Ignored Preview Oct 2, 2026 4:08pm UTC

Request Review

@cursor

cursor Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Only GitHub review routing in CODEOWNERS changes; no application or runtime behavior.

Overview
Expands .github/CODEOWNERS so review routing matches major areas of the repo: Rust (*.rs, Cargo.toml, hashql/harpc), design system (hashdotdesign and ds-* libs), Petrinaut apps/libs, and backend (hash-api, hash-graph, @local/graph), with migration paths still owned by backend.

Legal coverage now uses a single LICENSE* pattern (so variants like LICENSE-MIT.md are included) instead of three fixed filenames. Rules are reordered so broader path rules (e.g. migrations, turbo, env) no longer override more specific ones—especially legal on license files under paths that also have backend owners, since GitHub applies last match wins.

Reviewed by Cursor Bugbot for commit 880a879. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added the area/infra Relates to version control, CI, CD or IaC (area) label Oct 2, 2026
@CiaranMn
CiaranMn added this pull request to the merge queue Oct 2, 2026
Merged via the queue into main with commit 2793601 Oct 2, 2026
45 checks passed
@CiaranMn
CiaranMn deleted the cm/update-codeowners branch October 2, 2026 18:05

This branch was successfully deployed

1 active deployment
Preview – petrinaut — 880a879b Deployed Oct 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/infra Relates to version control, CI, CD or IaC (area)

Development

Successfully merging this pull request may close these issues.

3 participants