Fix normal-mode paste to insert at cursor - #1
Draft
hashkrish wants to merge 1 commit into
Draft
Conversation
edtui's default p uses append_str, which skips past the character under the cursor before inserting. Intercept p and bracketed paste in normal mode so text lands at the cursor position instead. Co-authored-by: Santhana Krishnan S <hashkrish@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In normal mode,
pand bracketed paste now insert at the cursor position instead of after the character under the cursor.edtui's default
Pasteaction usesappend_str, which advances one column before inserting. This wrapper interceptspin normal mode and routes paste through insert-mode positioning so text lands where the block cursor sits.Changes
pinEditorBuffer::handle_keywhen in normal modepand bracketed pasteTest plan
cargo fmtcargo clippy --all-targets(zero warnings)cargo test(all green)