[hathach]

Problem

The farm cannot run tinyusb's network HIL tests (device/net_lwip_webserver, hathach/tinyusb#3918) yet:

• The rigs' installed /usr/local/sbin/hil_root comes from farm.toml's agentrc pin, 12d1443, which predates the
  netns verb (hil_root: netns moves a board's USB network interface into a sandbox #486).
• iperf, which the test's client runs, is not in the farm's package list.

Solution

• farm.toml: the agentrc pin moves to 8ca6765, the hil_root: netns moves a board's USB network interface into a sandbox #486 merge, so setup.sh update reinstalls hil_root with
  netns. Between the two pins only hil_root.py changed, by that verb alone. usb_recover.sh and root_port_cycle.py
  are byte-identical, so every current caller of the rigs' root scripts keeps working.
• farm.toml: iperf (iperf2) joins the apt packages. It has no maintainer scripts, debconf question or service.
• verify.sh: an iperf -v check beside the other per-tool checks.
• README: the network HIL paragraph says setup.sh install installs iperf, and that a host in service needs
  apt-get install iperf by hand, since update installs no packages. Both rigs already have iperf 2.2.1: ci.lan's
  was installed by hand today, and tusb's owner already had it.

Full suite: 4900 passed, 128 skipped. farm.py validate passes for ci.toml and hfp.toml. hil_root.py at 8ca6765
is the file verified end to end on ci.lan's stm32f407disco running net_lwip_webserver (#486).

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 4cb775f6-e9d2-49e8-a437-c035bcd91420

Commits

Reviewing files that changed from the base of the PR and between 8ca6765 and ca3d8b5.

Files selected for processing: 3

• skills/hil-farm-setup/README.md
• skills/hil-farm-setup/scripts/farm.toml
• skills/hil-farm-setup/scripts/verify.sh

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[hathach]

@greptileai