Repository navigation
Conversation
dee077
force-pushed
the
feat/headlamp-k8s-plugin-names
branch
from
August 4, 2026 21:00
132407c to
3b78c85
Compare
skoeva
requested changes
Aug 5, 2026
skoeva
left a comment
skoeva
left a comment
Contributor
There was a problem hiding this comment.
don't think we need to be bumping the version numbers in this PR - that should be reserved for the next release. we can set this to draft for now
skoeva
marked this pull request as draft
August 5, 2026 13:35
dee077
force-pushed
the
feat/headlamp-k8s-plugin-names
branch
from
August 8, 2026 23:01
3b78c85 to
5a87909
Compare
dee077
marked this pull request as ready for review
August 21, 2026 23:11
dee077
requested review from
ashu8912,
illume,
joaquimrocha,
sniok,
vyncent-t and
yolossn
as code owners
August 21, 2026 23:11
dee077
force-pushed
the
feat/headlamp-k8s-plugin-names
branch
from
September 8, 2026 06:59
5a87909 to
cf5b9bc
Compare
Author
Updates
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
App-catalog formatting CI fails, migration coverage is missing, and publication depends on an unmerged core de-duplication change.
Review effort: Balanced
Findings: 1
Open (4)
What changed in this PR
Scopes the app-catalog and Prometheus plugin identities under @headlamp-k8s; despite the metadata, kmesh is unchanged.
Changes:
- Renames both npm packages and lockfile roots.
- Updates settings links and Prometheus registration identity.
- Preserves Prometheus configuration under its legacy storage key.
| File | Description |
|---|---|
app-catalog/package.json |
Applies the scoped package name. |
app-catalog/package-lock.json |
Regenerates lock metadata. |
app-catalog/src/components/charts/SettingsLink.tsx |
Routes to the scoped plugin details. |
prometheus/package.json |
Applies the scoped package name. |
prometheus/package-lock.json |
Regenerates lock metadata. |
prometheus/src/util.ts |
Separates plugin identity from the legacy configuration key. |
Files not reviewed (2)
- app-catalog/package-lock.json: Generated file
- prometheus/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Match the scope already used by the other plugins in this repo. Signed-off-by: dee077 <deepanshu.sahu27@gmail.com>
Match the scope already used by the other plugins in this repo. The config store keeps the old 'prometheus' key, so saved settings are not lost. Signed-off-by: dee077 <deepanshu.sahu27@gmail.com>
dee077
changed the title
dee077
force-pushed
the
feat/headlamp-k8s-plugin-names
branch
from
September 30, 2026 17:20
cf5b9bc to
89938ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
app-catalogandprometheusplugin packages to the@headlamp-k8snpm scope (e.g.@headlamp-k8s/app-catalog), matching the scope already used by every other plugin in this repopackage-lock.jsonfor each of the three pluginsapp-catalog'sSettingsLinkto route viapluginDetailsusing the new scoped nameprometheus'sPLUGIN_NAMEconstant, which propagates the new name to settings registration, the config store, and the settings deep linkFixes kubernetes-sigs/headlamp#2597
Currently, both the old (unscoped) and new (
@headlamp-k8s-scoped) plugin show up, as seen below:Todo:
@headlamp-k8splugin is shown.