-
Notifications
You must be signed in to change notification settings - Fork 212
Add HIP: Check Kubernetes feature gates with a new flag in Chart #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rysurd
wants to merge
1
commit into
helm:main
Choose a base branch
from
rysurd:hip/kubefeaturegates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+58
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| --- | ||
| hip: 9999 | ||
| title: "Check Kubernetes feature gates with a new flag in Chart" | ||
| authors: [ "Idryss Bourdier <thegogolplex@gmail.com>" ] | ||
| created: "2026-08-11" | ||
| type: "feature" | ||
| status: "draft" | ||
| --- | ||
|
|
||
| ## Abstract | ||
|
|
||
| This proposal aims to resolve issue [31432](https://github.com/helm/helm/issues/31432), offering a way to check each Kubernetes feature gates within Chart.yaml. This is an extra layer of compatibility between a Chart and a cluster, on top of the `kubeVersion` field. When a Chart is installed or upgraded, it will poll the k8s cluster for its feature gates, either per components and per nodes or per a representative node. If a feature gate required isn't activated on the component as declared in Chart.yaml, the installation/upgrade will fail. | ||
|
|
||
| ## Motivation | ||
|
|
||
| There is currently no existing mecanism in Helm that allow polling to Kubernetes before CRDs installation and during installation/upgrade. Moreover, there is no mecanism in place that checks feature gates. | ||
|
|
||
| ## Specification | ||
|
|
||
| Adding a new field in Chart.yaml similar to this format: | ||
| ```yaml | ||
| kubeFeatureGatesPolling: representative #could also be a choice between representative, per nodes, node-name specific, etc | ||
| kubeFeatureGates: | ||
| kubelet: | ||
| SidecarContainers: true | ||
| apiserver: | ||
| ConstrainedImpersonation: true | ||
| scheduler: | ||
| ComponentFlagz: false | ||
| ``` | ||
|
|
||
| ## Backwards compatibility | ||
|
|
||
| Fully backward compatible. | ||
|
|
||
| ## Security implications | ||
|
|
||
| Since we allow Helm to poll Kubernetes components, we have to sanitize any input and output plus securize the channel. Also, we need to ensure that the Helm operator that is executing the k8s commands on the cluster have the rights to access required Kubernetes components. | ||
|
|
||
| ## How to teach this | ||
|
|
||
| This new field is opt-in and not used by default. It will be added to the documentation if implemented, with a guide on how to use this new feature. | ||
|
|
||
| ## Reference implementation | ||
|
|
||
| There is a pending PR on Helm repo ; [feat(action): add KubeFeatureGates field in Chart definition to check against k8s feature gates](https://github.com/helm/helm/pull/32497) | ||
|
|
||
| ## Rejected ideas | ||
|
|
||
| - | ||
|
|
||
| ## Open issues | ||
|
|
||
| I suggested that we implement a new feature in Kubernetes directly that would expose an endpoint, through the apiserver, that expose all feature gates information across all components and nodes. Ref ; [[Feature request] Single API endpoint for feature gates values](https://github.com/kubernetes/kubernetes/issues/141162) | ||
|
|
||
| ## References | ||
|
|
||
| - | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the chart declares this in its Chart.yaml but an older version of helm is used on that chart?