Repository navigation
Translate season leaderboard column headers - #2366
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hall of Fame leaderboard displayed raw field names such as
user_nameandtotal_pointsin every language. Translate all 11 headers using the existing locale catalogs, preserving the sorting keys. The shared season results table receives the same fix.Correct the Chinese rank label and the Spanish and Chinese best-finish labels to describe leaderboard positions.
Closes #2365.
Validation:
make test— 1610 passed, 48 excluded; 97.0% coverage.make test-fe— typecheck and production build passed.make lint-js— passed.make credo— strict analysis passed.make dialyzer— passed.GitHub CI passed compilation, formatting, and Credo, then failed at
mix hex.auditon advisories affecting the existingbandit 1.13.1andplug_crypto 2.2.0dependencies. Later CI steps were skipped. This PR does not change dependencies. CI run.