Repository navigation
feat: fold practice into the shared file, not project status - #32
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a91db818eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The fold prompt told the synthesizer to "fold the new memories into the file's curated sections" and nothing else, so it did exactly that — including a project's resume point, what was deployed, backlog counts and workflow ids, all merged into the file every agent on the machine reads. That had to be cut out by hand today, twice: once from the curated sections and once more after the next sync gathered the same memory stores again.
The prompt now says what the file is for. A new memory contributes the practice it teaches, never the status it records; anything that must be edited when work moves is dropped rather than folded; a memory that is entirely status contributes nothing; and the fallback
Promoted from <agent>section is no longer a home for status the rules just told the model to drop.There is no config route to this —
--only/--skipfilter which agents receive the file, not the gather — so it had to be the prompt.Validation: new assertions in
tests/fold_test.shpin that the rules are actually sent, mutation-proven by removing one rule and watching it fail. All 13 suites pass,sh -nandshellcheck -S errorclean.Note this carries a
VERSIONbump to 1.12.0, so merging it releases.