Repository navigation
test: cover sitemap stat fallback and hive release-branch version mapping - #349
Merged
hivecommons-hive[bot] merged 1 commit intoOct 16, 2026
Merged
Conversation
…ping sitemap.ts getLastModified() swallowed stat errors with a fresh Date but the catch path was never exercised; getVersionFromBranch() was only tested for main/master and unknown branches, never for the v4/v5/v6 release branches or docs/<key> branches it actually maps. Both files now report 100% in the Vitest coverage gate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kubestellar-prow
Bot
deleted the
quality/test-sitemap-mtime-fallback-barrels
branch
October 16, 2026 07:30
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Two residual uncovered paths in the Vitest coverage gate, both now at 100%:
src/app/sitemap.ts—getLastModified()falls back tonew Date()whenfs.statSyncthrows (line 49 was the only uncovered line in the file). New test stubsstatSyncto throwEACCESfor one linked docs file and asserts the entry still appears with a current-timelastModified.src/config/versions.ts—getVersionFromBranch()was tested only formain/master, unknown branches and an unmatcheddocs/*. It was never pinned for the branches it actually maps: the hive release branchesv5(thestablechannel andsync-hive-docsdefault ref) →latest,v6,v4, anddocs/<version-key>(lines 242, 253 uncovered).No production code changed; no changelog fragment per
changelog.d/README.md(test-only).Verified locally:
npx vitest run --coverage→ 106 files / 1096 tests pass, gate thresholds met;eslint,tsc --noEmit,prettier --checkclean on the touched files.Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88