Repository navigation
test: probe the URI fields of .well-known/security.txt in check-links.sh - #194
Merged
Merged
Conversation
check-links.sh harvested links from committed *.html pages and the make-redirects.sh map only, so the https Contact and Policy URIs in .well-known/security.txt were never probed: a rotted security contact would stay unseen by the weekly external-link run even though the availability probe fetches the file itself. Harvest the RFC 9116 URI fields (Contact, Canonical, Policy, Acknowledgments, Hiring) into the same link list. mailto: contacts are skipped as before, Canonical resolves against the tree like any site URL, and comment lines are ignored. Three new self-test cases cover the probe, an unpublished Canonical, and a site without the file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
3 tasks
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
scripts/check-links.shonly harvested links from committed*.htmlpages and themake-redirects.shmap, so thehttps://Contact:andPolicy:URIs in.well-known/security.txtwere never probed — a rotted security contact would stay invisible to the weekly external-link run even though the availability probe fetches the file itself.This adds an
extract_security_txt_urissource that feeds the RFC 9116 URI fields (Contact,Canonical,Policy,Acknowledgments,Hiring) into the same link list, attributed to.well-known/security.txt:mailto:contacts are skipped by the existing scheme filter (not flagged);Canonicalgoes through the site-URL branch and must resolve to a committed file;#comment lines and non-URI fields (Expires,Preferred-Languages) are ignored.Self-test (
check-links.test.sh, 45 → 57 assertions) adds three cases: rotted Contact/Acknowledgments/Hiring are reported and attributed tosecurity.txtwhile a resolvingPolicyis not counted; an unpublishedCanonicalis an internal error even under--external-warn; a site without the file is unaffected. README documents the extra source.Verified @0397beb:
check-links.test.sh57/57,check-redirects.test.sh28/28,node --test scripts/*.test.mjs594/594; offline run of the checker over the live tree now reports 175 unique links (was 172: +https Contact, +Policy, +Canonical), 0 internal errors.Closes #193
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1