Give the Front Door page an actual Purpose section - #636
Open
duncancrawford wants to merge 1 commit into
Open
Conversation
The page carried an empty '## Purpose' heading, which rendered as a bare heading with nothing under it and put an empty entry in the page contents. The sentence that belongs there already existed - it was just filed under Configuration - so this moves it up rather than writing anything new. Also moves the review date on, which is what #598 set out to do. Co-authored-by: james-matthews1 <james-matthews1@users.noreply.github.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #598, and carries its review-date bump.
The defect
front-door.html.md.erbhad an empty## Purposeheading — a heading with nothing under it, which renders as a bare heading on the page and adds an empty entry to the page contents.The sentence that belongs under Purpose already existed; it was just filed under
## Configuration:So this moves that sentence up under Purpose. No new prose — a reorder, so there is nothing here to fact-check.
Why not just the date
#598 moved
last_reviewed_onand nothing else. A review that only moves the stamp asserts someone looked at the page while leaving its actual defects in place. This does the same date bump and fixes what reading the page turns up.Co-authored with @james-matthews1, whose review this carries forward.
Raised separately rather than guessed at
Two things I could not resolve from the repo, so they are issues rather than edits here — see the linked issues.