HDPI-5498: caseworker respond to claim - #2464
Open
gmmagruder wants to merge 20 commits into
Open
Conversation
# Conflicts: # src/main/java/uk/gov/hmcts/reform/pcs/ccd/domain/PCSCase.java # src/main/java/uk/gov/hmcts/reform/pcs/ccd/event/EventId.java
CCD diff summary👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/32945019496?check_suite_focus=true CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/wlu-team-leader.json
AuthorisationCaseField/wlu-admin.json
AuthorisationCaseField/leadership-judge.json
AuthorisationCaseField/judge.json
AuthorisationCaseField/hearing-centre-team-leader.json
AuthorisationCaseField/hearing-centre-admin.json
AuthorisationCaseField/fee-paid-judge.json
AuthorisationCaseField/ctsc.json
AuthorisationCaseField/ctsc-team-leader.json
AuthorisationCaseField/circuit-judge.json
CaseEvent/defendantPaperResponse.json
CaseEventToFields/defendantPaperResponse.json
FixedLists/ContactPreferencesSelection.json
|
…nt, ui inconsistencies and add validation for defendant submitted
# Conflicts: # src/main/java/uk/gov/hmcts/reform/pcs/ccd/event/EventId.java
linusnorton
reviewed
Aug 21, 2026
| } | ||
|
|
||
| private VerticalYesNo isNameConfirmed(String firstName, String lastName, PartyEntity partyEntity) { | ||
| if (StringUtils.isBlank(firstName) & StringUtils.isBlank(lastName)) { |
linusnorton
reviewed
Aug 21, 2026
|
|
||
| private final DefendantResponseRepository defendantResponseRepository; | ||
| private static final String ERROR_MESSAGE = "This defendant has already submitted a response." | ||
| + " If the have filed a further response please use the upload document function."; |
Contributor
There was a problem hiding this comment.
If the have ... should be "If they have..."?
linusnorton
reviewed
Aug 21, 2026
| return defendantResponseRepository.existsByClaimPcsCaseCaseReferenceAndPartyIdamId(caseReference, userId); | ||
| } | ||
|
|
||
| private ClaimEntity getClaimEntity(long caseReference) { |
Contributor
There was a problem hiding this comment.
nothing seems to call this
Contributor
Author
There was a problem hiding this comment.
Removed redundant code
linusnorton
reviewed
Aug 21, 2026
| } | ||
|
|
||
| public static State[] paperResponseDefendant() { | ||
| return new State[] { |
Contributor
There was a problem hiding this comment.
this should just call createFlags() for now
arun-hmcts
reviewed
Aug 21, 2026
|
|
||
| private final DefendantResponseRepository defendantResponseRepository; | ||
| private static final String ERROR_MESSAGE = "This defendant has already submitted a response." | ||
| + " If the have filed a further response please use the upload document function."; |
Contributor
There was a problem hiding this comment.
Typo: "If the have filed" -> "If they have filed".
linusnorton
approved these changes
Aug 21, 2026
arun-hmcts
approved these changes
Aug 21, 2026
scottstewart-sl
approved these changes
Aug 21, 2026
| private String buildPartyDisplayName(PartyEntity partyEntity) { | ||
| if (partyEntity.getNameKnown() == VerticalYesNo.NO) { | ||
| return "Person unknown"; | ||
| } |
Contributor
There was a problem hiding this comment.
Minor partyService.getPartyName(partyEntity) already has this check.
(I can update this PR and check it)
marianadpereira
added
enable_e2e_test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
See HDPI-5498
Change description
Testing done
Manual testing locally and unit tests
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist
PCS checklist
@EnabledIfEnvironmentVariable(named = "CCD_ENABLED", ...)+ shutter guard) unless they must run on unlabelled PRs (HDPI-8084)