Conversation
Allows Home Assistant and others to pass a shared client instead of creating a new client for every request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Currently a new client is created for every new request:
python-luftdaten/luftdaten/__init__.py
Lines 27 to 29 in d383f2f
This PR allows callers to pass their own session. This allows it to be reused and also will help fix a home assistant issue. I'll open another PR there once this is added.
Related to home-assistant/core#173879
Existing behavior is preserved when no client is provided.
Please let me know if you want any changes :)