Repository navigation
CDEV-1276: update Node to 24 and fix npm audit - #300
Merged
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 7e74911): https://hw-api-documentation--pr300-cdev-1276-update-nod-aztne0l1.web.app (expires Thu, 05 Nov 2026 13:17:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4accc1c887f1346ec9c563d5645c74c94f610c07 |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
rvandernoort
force-pushed
the
cdev-1276-update-node-and-audit
branch
from
October 29, 2026 13:15
8fc1a70 to
7e74911
Compare
hoefnageltom
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api-documentation is a static Docusaurus site served from Firebase Hosting, so the Node.js Brotli decoder CVE (CVE-2026-111497, Node2Shell) does not apply to a running server here. What is exposed is the Node version used to build and preview the site (CI, the deploy workflow and local
npm start), plus the dependency tree. This PR updates and hardens both, as part of CDEV-1276.ci.yaml,firebase-hosting-merge.ymlandfirebase-hosting-pull-request.yml(a floating24, so the build picks up the patched 24.22.1 or later), README, andengines.node≥ 24.22.1.npm audit: 68 findings (19 critical, 25 high, 15 moderate, 9 low) down to 6 (5 low, 1 moderate):npm audit fixbrings Docusaurus to 3.10.2 and fixes the rest of the high/critical tree;overridesfortinypool(^2.2.0, pinned by@docusaurus/core, critical RCE gadget) anduuid(^11.1.1, dev-serversockjs).resolvedhosts; only new or changed entries point to the klingon registry.npm run format-checkformatting is kept.Still open (6):
@docusaurus/preset-classic/plugin-svgr/@svgr/*/deepmerge(low; audit only offers a downgrade to 3.7.0) andqs(moderate, from the dev-serverexpress).Verification
Node 24.22.1 / npm 11:
npm ci,npm run lint,npm run format-check,npm run spell-checkerandnpm run build(full production build, client and server compiled) pass.Not verified: the visual result of the built site against the current production site (Docusaurus 3.9 → 3.10,
tinypool1 → 2 in the build workers). Please check the Firebase preview channel that this PR deploys before merging.Rollback
Revert the PR; the site is static and there is no data.
🤖 Generated with Claude Code