Skip to content

CDEV-1276: update Node to 24 and fix npm audit - #300

Merged
rvandernoort merged 1 commit into
mainfrom
cdev-1276-update-node-and-audit
Oct 29, 2026
Merged

rvandernoort merged 1 commit into
mainfrom
cdev-1276-update-node-and-audit

Conversation

@rvandernoort

Copy link
Copy Markdown
Contributor

Summary

api-documentation is a static Docusaurus site served from Firebase Hosting, so the Node.js Brotli decoder CVE (CVE-2026-111497, Node2Shell) does not apply to a running server here. What is exposed is the Node version used to build and preview the site (CI, the deploy workflow and local npm start), plus the dependency tree. This PR updates and hardens both, as part of CDEV-1276.

  • Node 20.20.1 → 24 in ci.yaml, firebase-hosting-merge.yml and firebase-hosting-pull-request.yml (a floating 24, so the build picks up the patched 24.22.1 or later), README, and engines.node ≥ 24.22.1.
  • npm audit: 68 findings (19 critical, 25 high, 15 moderate, 9 low) down to 6 (5 low, 1 moderate):
    • npm audit fix brings Docusaurus to 3.10.2 and fixes the rest of the high/critical tree;
    • overrides for tinypool (^2.2.0, pinned by @docusaurus/core, critical RCE gadget) and uuid (^11.1.1, dev-server sockjs).
  • Lockfile: the existing entries keep their original resolved hosts; only new or changed entries point to the klingon registry. npm run format-check formatting is kept.

Still open (6): @docusaurus/preset-classic / plugin-svgr / @svgr/* / deepmerge (low; audit only offers a downgrade to 3.7.0) and qs (moderate, from the dev-server express).

Verification

Node 24.22.1 / npm 11: npm ci, npm run lint, npm run format-check, npm run spell-checker and npm run build (full production build, client and server compiled) pass.

Not verified: the visual result of the built site against the current production site (Docusaurus 3.9 → 3.10, tinypool 1 → 2 in the build workers). Please check the Firebase preview channel that this PR deploys before merging.

Rollback

Revert the PR; the site is static and there is no data.

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 7e74911):

https://hw-api-documentation--pr300-cdev-1276-update-nod-aztne0l1.web.app

(expires Thu, 05 Nov 2026 13:17:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4accc1c887f1346ec9c563d5645c74c94f610c07

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@rvandernoort
rvandernoort force-pushed the cdev-1276-update-node-and-audit branch from 8fc1a70 to 7e74911 Compare October 29, 2026 13:15
@rvandernoort
rvandernoort merged commit 571384a into main Oct 29, 2026
10 checks passed
@rvandernoort
rvandernoort deleted the cdev-1276-update-node-and-audit branch October 29, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants