Fix auto-pagination undercounting pages when the API caps page size

[Robbie-Renada]

Summary

• New-HaloGETRequest's auto-pagination works out how many pages to fetch as Ceiling(record_count / <requested page_size>). The Halo API can silently cap the number of records actually returned per page below the requested page_size (e.g. asking for page_size=1000 but only ever getting 100 back), so that calculation is frequently wrong and every Get-Halo* multi-mode cmdlet ends up silently returning only the first page of results whenever the real result set is bigger than the API's true per-page cap — no error, just fewer records than actually exist.
• Fix: capture the actual size of the first page returned and use that consistently for every later page-count calculation, instead of trusting the requested page size. A short final page (the normal end-of-results case) no longer skews the page count computed for earlier pages.
• Added a regression test (keeps paginating when the API returns fewer records per page than requested) that reproduces the bug: requests page_size=1000 against a mocked 250-record endpoint that only ever returns 100 per page, and asserts all 250 records come back across 3 requests.

Confirmed empirically against a real Halo tenant before writing the fix: Get-HaloTicket (no -PageSize) returned only 100 of 717 real tickets; requesting page_size=1000 directly against api/tickets still only returned 100 records per page even though record_count correctly reported 717.

Fixes #90

Test plan

• Invoke-Pester on Tests/HaloAPI.Unit.Tests.ps1 — all 452 tests pass (451 existing + 1 new), no regressions.
• DevOps/Quality/run-pssa.ps1 — no new PSScriptAnalyzer findings introduced by either changed file.

🤖 Generated with Claude Code

[Copilot]

🟢 Approval recommended

The implementation directly addresses the undercount and includes focused regression coverage.

Pull request overview

Fixes silent result truncation when Halo caps API page sizes below the requested value.

Changes:

• Calculates page count using the first response’s actual item count.
• Adds regression coverage for a 250-record, three-page response.

File summaries

File	Description
Private/New-HaloGETRequest.ps1	Uses the effective API page size for pagination.
Tests/HaloAPI.Unit.Tests.ps1	Verifies capped pages are fully retrieved.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[codecov]

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.92%. Comparing base (9ee9190) to head (a48ad98).

Files with missing lines	Patch %	Lines
Private/New-HaloGETRequest.ps1	88.88%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop      #91      +/-   ##
===========================================
+ Coverage    69.88%   69.92%   +0.04%     
===========================================
  Files          229      229              
  Lines         3712     3717       +5     
===========================================
+ Hits          2594     2599       +5     
  Misses        1118     1118              

Flag	Coverage Δ
meta	0.40% <0.00%> (-0.01%)	⬇️
unit	69.92% <88.88%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

[homotechsual]

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review. ✅ Project coverage is 69.92%. Comparing base (9ee9190) to head (a48ad98).

Files with missing lines Patch % Lines
Private/New-HaloGETRequest.ps1 88.88% 1 Missing ⚠️
Additional details and impacted files

@@             Coverage Diff             @@
##           develop      #91      +/-   ##
===========================================
+ Coverage    69.88%   69.92%   +0.04%     
===========================================
  Files          229      229              
  Lines         3712     3717       +5     
===========================================
+ Hits          2594     2599       +5     
  Misses        1118     1118              

Flag Coverage Δ
meta 0.40% <0.00%> (-0.01%) ⬇️
unit 69.92% <88.88%> (+0.04%) ⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness. 📢 Have feedback on the report? Share it here.

False positive due to assignment of do-while loop. Coverage is good.

[homotechsual]

Fixes #90