Remove base64 from sig manifest - #852
Merged
Merged
Conversation
Base64 was dropped from the runtime dependency in favor of the vendored HTTP::Base64. The stale manifest entry causes rbs collection to warn when the base64 gem is absent, particularly for Ruby >= 3.4 users.
hakanensari
pushed a commit
to lineofflight/amazon-ads-ruby
that referenced
this pull request
Aug 25, 2026
Http 6 includes RBS signatures, sourcing types from the gem instead of gem_rbs_collection. Add base64 to ignore list as http 6 declares stale base64 dependency (httprb/http#852).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#778 dropped the runtime dependency on the base64 gem in favor of the vendored
HTTP::Base64, but the entry insig/manifest.yamlwas left behind. Because of it,rbs collectionwarns for consumers whose bundle lacks the base64 gem (the default on Ruby >= 3.4, where base64 is no longer a default gem):The signatures define their own
HTTP::Base64module and reference nothing from the realBase64, so the dependency can go.rake steeppasses with the entry removed.