Repository navigation
fix(browser): keep the spaces of words built one element per letter - #105
Merged
Merged
Conversation
The page reader dropped text nodes made of spaces alone. example.com's script now puts each letter of its English text in its own span, spaces included, so the bot read "Thisdomainisforuse...". A text node of spaces is one space now; spaces in a row still collapse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while doing the real Claude Code checks owed by #62: a bot read example.com's text with no spaces between words ("Thisdomainisforuse…"), and said so itself.
<span>, spaces included (<span> </span>). The page reader (reader.js) dropped text nodes made of spaces alone, so the words ran together. The Arabic text was fine, because the script keeps the space with each word there.words_made_of_one_element_per_letter_keep_their_spacesfails onmain("Twowords") and passes here. The browser test files passed three times in a row on Windows.