Repository navigation
fix(app): a reloaded page replaces its tray icon instead of adding one - #113
Merged
Merged
Conversation
The tray icon lives in the app process, not in the page. After a reload (dev hot reload, or the webview reloading) the page forgot the icon it had made and created a second one with the same id. Before creating its icon, the page now removes any `botloft` icon left behind. A dev build runs beside the installed app, so its tray tooltip ends in "(dev)" to tell the two apart. Spec 15.2 updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
botlofticon next to the clock. Now, before creating its icon, the page removes anybotlofticon left behind (TrayIcon.getById/removeById).(dev).Tests
app/src/lib/tauriTray.test.ts(new): two concurrent updates keep one icon; a reloaded module replaces the icon left behind.pnpm checkpasses locally (typecheck, biome, 279 tests).Manual check (real app)
pnpm tauri devwith the devBOTLOFT_HOME, with the installed Botloft also running.Botloft: … (dev).