Repository navigation
feat(app): soft sounds for a message sent, a reply, a file and a new bot - #129
Merged
Merged
Conversation
The app only chimed for notifications. Now, while Botloft is in front, it also plays quieter sounds made on the spot, in the same timbre: a tick when the owner's message leaves, a pop for a reply in the open chat, two bright notes for a file shared there, and a rising spark when a bot or a crew is born. "App sounds" in Settings > Notifications turns them off (on by default). Nothing plays within 1.5 s of another sound, except a bot that needs the owner. chime.ts becomes tones.ts (the notes) and sounds.ts (when to play). Spec 15.1 updated.
Owner
Author
|
Manual test: the owner listened in the real app (pnpm local, 0.9.0 build) and the sounds are good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Botloft only made a sound for notifications. A few soft sounds at the right moments make the app feel more alive, as long as they stay rare and quiet.
What
While Botloft is in front, with App sounds on (Settings > Notifications, on by default):
chime.tsbecomestones.ts(the notes) andsounds.ts(when to play). Notification chimes still follow "Play a sound".Checks
shell/sounds.test.tsx, with the synth mocked): tick on send and silence with the switch off; reply and file only in the open chat; spark for a new bot and nothing while behind; the 1.5 s gap and the exception for "needs".pnpm checkpasses (291 tests).Manual test