Repository navigation
fix(app): retry an update whose installer did not start - #130
Merged
Merged
Conversation
Before it runs the Windows installer, the updater plugin calls cleanup_before_exit: it hides the window, drops the tray icon and frees every resource the page holds, the found update included. When the installer then fails to start (UAC declined, an antivirus blocks it), the app keeps running without them, and Try again failed with "The resource id ... is invalid". After a failed install, show the window, rebuild the tray icon and look for the update again on the next try. Spec 15.5 records why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a failed update install on Windows, Try again failed with
The resource id … is invalid(seen on a friend's PC on 0.9.0).Cause:
tauri-plugin-updaterrunscleanup_before_exitright beforeShellExecuteWon the installer. That hides the window, removes the tray icon and clears every resource table. If the installer then fails to start (UAC declined, an antivirus blocks it), the app keeps running, but theUpdatehandle and the tray are gone.tauriHost: after a failed install, close the old handle, show the window, rebuild the tray and forget the taskbar overlay image. The next try callscheck()again.tauriTray:rebuildTray()makes the icon again from the last view.Manual test (needs a real release): on 0.9.0 → newer, click Update now, decline the UAC prompt (or block the installer). The window comes back with the error, the tray icon is still there, and Try again installs.
🤖 Generated with Claude Code